Re: xtables-addons - problem including nf_nat.h in userspace plugin

[Patrick McHardy <kaber@trash.net>]

On 22.11.2010 14:52, Jan Engelhardt wrote:
> 
> On Sunday 2010-11-21 22:47, Marek Kierdelewicz wrote:
>>
>> I'm writing a new netfilter module and I'm using xtables-addons[...]
>> Iptables userspace plugin for the module needs definition of "struct
>> nf_nat_multi_range", so I added following line to libxt_xxxx.c:
>> #include <net/netfilter/nf_nat.h>
>> Unfortunately I get following message during make: 
>> warning: net/netfilter/nf_nat.h: No such file or directory
>> ... and compilation fails.
>> I was able to make it work by copying nf_nat.h and nf_conntrack_tuple.h
>> to extension directory in xtables-addons tree and by modifying include
>> in libxt_xxxx.c to "nf_nat.h", but this doesn't seem to be the proper
>> way of doing things.
> 
> Well, iptables also copies them rather than properly relying on
> something from <linux/*>. Yes, it's not proper. Patrick should know
> the details about the what and why.

Mainly to allow to compile new extensions before the kernel headers
are updated. Including files from include/net is wrong though, they
should be moved to include/linux instead.