From mboxrd@z Thu Jan 1 00:00:00 1970 From: Timur Tabi Subject: Re: [PATCH v2] ASoC: atmel: test wrong variable Date: Mon, 22 Nov 2010 10:04:37 -0600 Message-ID: <4CEA9495.8040605@freescale.com> References: <1290361216-15166-1-git-send-email-segoon@openwall.com> <20101122094353.f76830b5.jhnikula@gmail.com> <20101122155913.GA9089@albatros> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from AM1EHSOBE004.bigfish.com (am1ehsobe004.messaging.microsoft.com [213.199.154.207]) by alsa0.perex.cz (Postfix) with ESMTP id C95592432C for ; Mon, 22 Nov 2010 17:05:18 +0100 (CET) Received: from mail65-am1 (localhost.localdomain [127.0.0.1]) by mail65-am1-R.bigfish.com (Postfix) with ESMTP id 040921348170 for ; Mon, 22 Nov 2010 16:05:10 +0000 (UTC) Received: from AM1EHSMHS006.bigfish.com (unknown [10.3.201.240]) by mail65-am1.bigfish.com (Postfix) with ESMTP id B10E91A585E9 for ; Mon, 22 Nov 2010 16:04:44 +0000 (UTC) Received: from de01smr02.am.mot.com (de01smr02.freescale.net [10.208.0.151]) by de01egw02.freescale.net (8.14.3/8.14.3) with ESMTP id oAMG4ctf013087 for ; Mon, 22 Nov 2010 09:04:39 -0700 (MST) Received: from az33exm25.fsl.freescale.net (az33exm25.am.freescale.net [10.64.32.16]) by de01smr02.am.mot.com (8.13.1/8.13.0) with ESMTP id oAMGMJcb014505 for ; Mon, 22 Nov 2010 10:22:19 -0600 (CST) In-Reply-To: <20101122155913.GA9089@albatros> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Vasiliy Kulikov Cc: alsa-devel@alsa-project.org, Lars-Peter Clausen , Takashi Iwai , Mark Brown , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Liam@alsa-project.org, Girdwood List-Id: alsa-devel@alsa-project.org Vasiliy Kulikov wrote: > After clk_get() mclk is checked second time instead of pllb check. > In patch v1 Jarkko Nikula noticed that PTR_ERR() is also has wrong argument. > > Signed-off-by: Vasiliy Kulikov Why am I'm being cc'd on Atmel driver patches? I've done no work on these drivers. -- Timur Tabi Linux kernel developer at Freescale From mboxrd@z Thu Jan 1 00:00:00 1970 From: Timur Tabi Date: Mon, 22 Nov 2010 16:04:37 +0000 Subject: Re: [PATCH v2] ASoC: atmel: test wrong variable Message-Id: <4CEA9495.8040605@freescale.com> List-Id: References: <1290361216-15166-1-git-send-email-segoon@openwall.com> <20101122094353.f76830b5.jhnikula@gmail.com> <20101122155913.GA9089@albatros> In-Reply-To: <20101122155913.GA9089@albatros> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Vasiliy Kulikov Cc: alsa-devel@alsa-project.org, Lars-Peter Clausen , Takashi Iwai , Mark Brown , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Liam@alsa-project.org, Girdwood Vasiliy Kulikov wrote: > After clk_get() mclk is checked second time instead of pllb check. > In patch v1 Jarkko Nikula noticed that PTR_ERR() is also has wrong argument. > > Signed-off-by: Vasiliy Kulikov Why am I'm being cc'd on Atmel driver patches? I've done no work on these drivers. -- Timur Tabi Linux kernel developer at Freescale From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756549Ab0KVQFG (ORCPT ); Mon, 22 Nov 2010 11:05:06 -0500 Received: from am1ehsobe006.messaging.microsoft.com ([213.199.154.209]:48478 "EHLO AM1EHSOBE006.bigfish.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751992Ab0KVQFE (ORCPT ); Mon, 22 Nov 2010 11:05:04 -0500 X-SpamScore: -12 X-BigFish: VS-12(zz1432N98dNzz1202hzz8275bhz2dh2a8h637h668h67dh685h61h) X-Spam-TCS-SCL: 0:0 X-Forefront-Antispam-Report: KIP:(null);UIP:(null);IPVD:NLI;H:az33egw01.freescale.net;RD:az33egw01.freescale.net;EFVD:NLI Message-ID: <4CEA9495.8040605@freescale.com> Date: Mon, 22 Nov 2010 10:04:37 -0600 From: Timur Tabi Organization: Freescale User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.15) Gecko/20101101 Fedora/2.0.10-1.fc13 SeaMonkey/2.0.10 MIME-Version: 1.0 To: Vasiliy Kulikov CC: , , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Lars-Peter Clausen , , Jarkko Nikula Subject: Re: [PATCH v2] ASoC: atmel: test wrong variable References: <1290361216-15166-1-git-send-email-segoon@openwall.com> <20101122094353.f76830b5.jhnikula@gmail.com> <20101122155913.GA9089@albatros> In-Reply-To: <20101122155913.GA9089@albatros> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 22 Nov 2010 16:05:45.0644 (UTC) FILETIME=[1EFA56C0:01CB8A5F] X-OriginatorOrg: freescale.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Vasiliy Kulikov wrote: > After clk_get() mclk is checked second time instead of pllb check. > In patch v1 Jarkko Nikula noticed that PTR_ERR() is also has wrong argument. > > Signed-off-by: Vasiliy Kulikov Why am I'm being cc'd on Atmel driver patches? I've done no work on these drivers. -- Timur Tabi Linux kernel developer at Freescale