From: Li Yewang <lyw@cn.fujitsu.com>
To: David Miller <davem@davemloft.net>
Cc: mzhang@mvista.com, netdev@vger.kernel.org
Subject: Re: possible kernel oops from user MSS
Date: Tue, 23 Nov 2010 10:48:46 +0800 [thread overview]
Message-ID: <4CEB2B8E.3090904@cn.fujitsu.com> (raw)
In-Reply-To: <20101112.152607.193708973.davem@davemloft.net>
At 2010-11-13 7:26, David Miller wrote:
> From: Min Zhang<mzhang@mvista.com>
> Date: Fri, 12 Nov 2010 14:59:58 -0800
>
>> Regarding commit 7a1abd08d52fdeddb3e9a5a33f2f15cc6a5674d2 ("tcp:
>> Increase TCP_MAXSEG socket option minimum"). What is the reason
>> TCP_MAXSEG minimum be 64? Isn't the exact be 40 which is
>> TCPOLEN_MD5SIG_ALIGNED(20) + TCPOLEN_TSTAMP_ALIGNED(12) + 8?
>>
>> Or is it better to use TCP_MIN_MSS from tcp.h:
>>
>> /* Minimal accepted MSS. It is (60+60+8) - (20+20). */
>> #define TCP_MIN_MSS 88U
>
> I suppose TCP_MIN_MSS would be better to use, I'll make that
> change, thanks.
David, do you have plan to fix this bug using TCP_MIN_MSS?
next prev parent reply other threads:[~2010-11-23 2:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-10 13:24 possible kernel oops from user MSS Steve Chen
2010-11-10 20:41 ` David Miller
2010-11-11 5:15 ` Shan Wei
2010-11-11 5:33 ` David Miller
2010-11-11 5:36 ` David Miller
2010-11-11 5:37 ` Shan Wei
[not found] ` <AANLkTin-gXceUQxKvQeP8Nc8oXZDJnyjoFUjYD5x_g_y@mail.gmail.com>
2010-11-12 22:59 ` Min Zhang
2010-11-12 23:26 ` David Miller
2010-11-23 2:48 ` Li Yewang [this message]
2010-11-23 2:59 ` David Miller
2010-11-24 19:47 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CEB2B8E.3090904@cn.fujitsu.com \
--to=lyw@cn.fujitsu.com \
--cc=davem@davemloft.net \
--cc=mzhang@mvista.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.