From: Boaz Harrosh <bharrosh@panasas.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: nab@linux-iscsi.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH 2/3] target: simplify cmd to task mapping
Date: Tue, 23 Nov 2010 11:52:39 +0200 [thread overview]
Message-ID: <4CEB8EE7.80106@panasas.com> (raw)
In-Reply-To: <20101122210707.GA25898@infradead.org>
On 11/22/2010 11:07 PM, Christoph Hellwig wrote:
> On Thu, Nov 18, 2010 at 02:07:17PM +0200, Boaz Harrosh wrote:
>> If all these are mutual exclusive (if..elseif..else) can we not make
>> them an enum and switch() for costless-ness and clarity?
>
> We could. But IMHO we should simply get rid of all the special cases
> instead. First remove the non-SG case, then fold the zero transfer
> length one in as a special zero-length SG and then check how many
> differences we have left between the data and control plane.
>
ACK ^3
Boaz
prev parent reply other threads:[~2010-11-23 9:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-17 21:38 [PATCH 2/3] target: simplify cmd to task mapping Christoph Hellwig
2010-11-17 22:40 ` Nicholas A. Bellinger
2010-11-17 22:47 ` Nicholas A. Bellinger
2010-11-17 22:51 ` Christoph Hellwig
2010-11-18 0:41 ` Nicholas A. Bellinger
2010-11-18 12:07 ` Boaz Harrosh
2010-11-22 21:07 ` Christoph Hellwig
2010-11-23 9:52 ` Boaz Harrosh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CEB8EE7.80106@panasas.com \
--to=bharrosh@panasas.com \
--cc=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=nab@linux-iscsi.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.