From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============3511248660331861969==" MIME-Version: 1.0 From: Denis Kenzior Subject: Re: [PATCH -v3 3/3] modem: add support to restore state when resetting the modem Date: Tue, 23 Nov 2010 05:04:40 -0600 Message-ID: <4CEB9FC8.6080504@gmail.com> In-Reply-To: <1290202590-23190-3-git-send-email-padovan@profusion.mobi> List-Id: To: ofono@ofono.org --===============3511248660331861969== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi Gustavo, On 11/19/2010 03:36 PM, Gustavo F. Padovan wrote: > --- > src/modem.c | 74 ++++++++++++++++++++++++++++++++---------------------= ----- > 1 files changed, 41 insertions(+), 33 deletions(-) > = Ah ok, you implement the getting back to online process in this patch. Ignore my previous comment. > diff --git a/src/modem.c b/src/modem.c > index e57f8fc..704de29 100644 > --- a/src/modem.c > +++ b/src/modem.c > @@ -61,6 +61,7 @@ enum modem_state { > struct ofono_modem { > char *path; > enum modem_state modem_state; > + enum modem_state old_state; Can we simply use a boolean like 'get_online' that is FALSE by default, but gets set to TRUE (assuming we're online) during a silent reset? This can then get re-used for implementing of the Lockdown property as well. It also seems that the 'reset' value is not really needed. Regards, -Denis --===============3511248660331861969==--