Re: [PATCH] MIPS: Fix build failure for IP22

[Sergei Shtylyov <sshtylyov@mvista.com>]

Hello.

On 23-11-2010 14:32, Dmitri Vorobiev wrote:

> Commit 48e1fd5a81416a037f5a48120bf281102f2584e2 changed the name

    Linus has asled to also specify the commit summary in parens.

> of the MIPS-specific dma_cache_sync() routine by prefixing it with
> `mips_', and removed the export for its symbol. Two drivers, which
> did use dma_cache_sync(), namely, sgiseeq and sgiwd93, were not
> converted to use the new function, which led to build failure for
> the IP22 platform.

> This patch fixes the build failure by fixing the call sites of
> mips_dma_cache_sync() and exporting the symbol for this routine as
> a GPL symbol. While at it, some minor changes to improve Kconfig
> help entries were done.

> Signed-off-by: Dmitri Vorobiev<dmitri.vorobiev@movial.com>
[...]

> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> index f6668cd..fe64edc 100644
> --- a/drivers/net/Kconfig
> +++ b/drivers/net/Kconfig
> @@ -1925,6 +1925,9 @@ config SGISEEQ
>   	  Say Y here if you have an Seeq based Ethernet network card. This is
>   	  used in many Silicon Graphics machines.
>
> +	  To compile this driver as a module, choose M here: the module
> +	  will be called sgiseeq.
> +

    This change is not metioned in the patch description...

> diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
> index 8616496..2d868bf 100644
> --- a/drivers/scsi/Kconfig
> +++ b/drivers/scsi/Kconfig
> @@ -390,6 +390,9 @@ config SGIWD93_SCSI
>   	  If you have a Western Digital WD93 SCSI controller on
>   	  an SGI MIPS system, say Y.  Otherwise, say N.
>
> +	  To compile this driver as a module, choose M here: the
> +	  module will be called sgiwd93.
> +

    This change is not metioned in the patch description...

> diff --git a/drivers/scsi/sgiwd93.c b/drivers/scsi/sgiwd93.c
> index fef0e3c..be9fc40 100644
> --- a/drivers/scsi/sgiwd93.c
> +++ b/drivers/scsi/sgiwd93.c
> @@ -95,7 +95,7 @@ void fill_hpc_entries(struct ip22_hostdata *hd, struct scsi_cmnd *cmd, int din)
>   	 */
>   	hcp->desc.pbuf = 0;
>   	hcp->desc.cntinfo = HPCDMA_EOX;
> -	dma_cache_sync(hd->dev, hd->cpu,
> +	mips_dma_cache_sync(hd->dev, hd->cpu,
>   		       (unsigned long)(hcp + 1) - (unsigned long)hd->cpu,
>   		       DMA_TO_DEVICE);

    Don't you want to move the aboev 2 lines to the right also? You're 
breaking the existing alignments and leaving alignment spaces intact...

WBR, Sergei