From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=55689 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PL4A1-0003Jq-Ez
	for qemu-devel@nongnu.org; Tue, 23 Nov 2010 20:28:38 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <wency@cn.fujitsu.com>) id 1PL49y-0004GC-Vz
	for qemu-devel@nongnu.org; Tue, 23 Nov 2010 20:28:37 -0500
Received: from [222.73.24.84] (port=64787 helo=song.cn.fujitsu.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <wency@cn.fujitsu.com>) id 1PL49y-0004Fo-JL
	for qemu-devel@nongnu.org; Tue, 23 Nov 2010 20:28:34 -0500
Message-ID: <4CEC6A56.8080309@cn.fujitsu.com>
Date: Wed, 24 Nov 2010 09:28:54 +0800
From: Wen Congyang <wency@cn.fujitsu.com>
MIME-Version: 1.0
References: <4CEB5406.3060300@cn.fujitsu.com>	<20101123104348.5d44e89e@doriath>
	<20101123113159.4aab053a@doriath>
In-Reply-To: <20101123113159.4aab053a@doriath>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: [Qemu-devel] Re: [PATCH] correct migrate_set_speed's args_type
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: armbru@redhat.com, qemu-devel <qemu-devel@nongnu.org>

At 2010=E5=B9=B411=E6=9C=8823=E6=97=A5 21:31, Luiz Capitulino Write:
> On Tue, 23 Nov 2010 10:43:48 -0200
> Luiz Capitulino <lcapitulino@redhat.com> wrote:
>=20
>> On Tue, 23 Nov 2010 13:41:26 +0800
>> Wen Congyang <wency@cn.fujitsu.com> wrote:
>>
>>> The args=5Ftype of migrate=5Fset=5Fspeed in qmp-commands.hx is wrong.
>>> When we set migrate speed by json, qemu will be core dumped.
>>>
>>> Signed-off-by: Wen Congyang
>>
>> Nice catch.
>>
>> Was caused by 07de3e60b05 and hence affects master only. Could you please
>> mention that in the commit log? Also, your email address is missing
>> in the signed-off-by line.
>=20
> There's another problem there: we used to accept a json number but now we
> accept only a json integer.

Do you mean the parameter passed to migrate=5Fset=5Fspeed by json should be
float or integer?

But in the function do=5Fmigrate=5Fset=5Fspeed(), we only accept a integer.

>=20
> Markus, are you aware of this change?
>=20
>>
>>>
>>> ---
>>>  qmp-commands.hx |    2 +-
>>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/qmp-commands.hx b/qmp-commands.hx
>>> index 793cf1c..16bdb08 100644
>>> --- a/qmp-commands.hx
>>> +++ b/qmp-commands.hx
>>> @@ -495,7 +495,7 @@ EQMP
>>> =20
>>>      {
>>>          .name       =3D "migrate=5Fset=5Fspeed",
>>> -        .args=5Ftype  =3D "value:f",
>>> +        .args=5Ftype  =3D "value:o",
>>>          .params     =3D "value",
>>>          .help       =3D "set maximum speed (in bytes) for migrations",
>>>          .user=5Fprint =3D monitor=5Fuser=5Fnoop,
>>
>=20
>=20