From: Paolo Bonzini <pbonzini@redhat.com>
To: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
Cc: Kevin Wolf <kwolf@redhat.com>,
Stefan Hajnoczi <stefanha@gmail.com>,
qemu-devel <qemu-devel@nongnu.org>,
Hannes Reinecke <hare@suse.de>, Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] Re: [PATCH 5/5] scsi-bsg: Add initial support for BSG based SCSIDeviceInfo
Date: Wed, 24 Nov 2010 10:07:47 +0100 [thread overview]
Message-ID: <4CECD5E3.6010007@redhat.com> (raw)
In-Reply-To: <1290588035-8950-1-git-send-email-nab@linux-iscsi.org>
On 11/24/2010 09:40 AM, Nicholas A. Bellinger wrote:
> From: Nicholas Bellinger<nab@linux-iscsi.org>
>
> This patch adds initial support for using the Linux BSG interface with write/read vectored
> AIO as a QEMU backstore (SCSIDeviceInfo) with hw/scsi-bus.c compatible HBA emulation.
>
> So far it has been tested with x86_64 host and guest using hw/megasas.c and TCM_Loop LLD
> Port LUNs. Because this patch uses struct iovec for struct sg_io_v4->d[out,in]_xferp payloads,
> which currently requires a patch to linux/block/bsg.c:bsg_map_hdr() in order to setup the
> user -> kernel iovecs. This patch can be found in lio-core-2.6.git here:
>
> commit fec4e8457c744de50e1ead69a36d5c4ee089d1ac
> Author: Nicholas Bellinger<nab@linux-iscsi.org>
> Date: Sun Jun 13 23:13:20 2010 -0700
>
> [BSG]: Add support for struct sg_io_v4->d[out,in]_iovec_count
>
> This also will only currently work with paired user/kernel (eg: 64bit user / 64bit kernel)
> because of different pointer sizes in struct iovec->iov_base.
>
> There are also two FIXMEs in hw/scsi-bsg.c:bsg_generic_initfn() related to extraction of
> SCSI LUN and device type values using BSG and required by QEMU-KVM.
Any reason why this should be a different driver than scsi-generic, i.e.
why the scsi-generic should not switch automatically between SG and BSG
depending on the kind of device being opened?
In fact, there is no reason why scsi-generic should use bounce buffers
rather than sg_iovec_t, so that most of the differences between
scsi-generic and scsi-bsg would go away.
Paolo
next prev parent reply other threads:[~2010-11-24 9:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-24 8:40 [Qemu-devel] [PATCH 5/5] scsi-bsg: Add initial support for BSG based SCSIDeviceInfo Nicholas A. Bellinger
2010-11-24 9:07 ` Paolo Bonzini [this message]
2010-11-24 9:08 ` [Qemu-devel] " Nicholas A. Bellinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CECD5E3.6010007@redhat.com \
--to=pbonzini@redhat.com \
--cc=hare@suse.de \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=nab@linux-iscsi.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.