All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wen Congyang <wency@cn.fujitsu.com>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: armbru@redhat.com, qemu-devel <qemu-devel@nongnu.org>
Subject: [Qemu-devel] [PATCH v2] correct migrate_set_speed's args_type
Date: Thu, 25 Nov 2010 09:06:05 +0800	[thread overview]
Message-ID: <4CEDB67D.9070904@cn.fujitsu.com> (raw)
In-Reply-To: <20101124154857.10657aa1@doriath>

The args_type of migrate_set_speed in qmp-commands.hx is wrong.
When we set migrate speed by json, qemu will be core dumped.

This bug was caused by 07de3e60b05 and hence affects master only.

Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>

---
 qmp-commands.hx |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/qmp-commands.hx b/qmp-commands.hx
index 793cf1c..16bdb08 100644
--- a/qmp-commands.hx
+++ b/qmp-commands.hx
@@ -495,7 +495,7 @@ EQMP
 
     {
         .name       = "migrate_set_speed",
-        .args_type  = "value:f",
+        .args_type  = "value:o",
         .params     = "value",
         .help       = "set maximum speed (in bytes) for migrations",
         .user_print = monitor_user_noop,
-- 1.7.1 

  reply	other threads:[~2010-11-25  1:05 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-23  5:41 [Qemu-devel] [PATCH] correct migrate_set_speed's args_type Wen Congyang
2010-11-23 12:43 ` [Qemu-devel] " Luiz Capitulino
2010-11-23 13:31   ` Luiz Capitulino
2010-11-24  1:28     ` Wen Congyang
2010-11-24 17:48       ` Luiz Capitulino
2010-11-25  1:06         ` Wen Congyang [this message]
2010-11-25 13:29           ` [Qemu-devel] Re: [PATCH v2] " Luiz Capitulino
2010-12-10 15:20     ` [Qemu-devel] Re: [PATCH] " Markus Armbruster
2010-12-10 15:33       ` Luiz Capitulino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CEDB67D.9070904@cn.fujitsu.com \
    --to=wency@cn.fujitsu.com \
    --cc=armbru@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.