All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@domain.hid>
To: Philippe Gerum <rpm@xenomai.org>
Cc: adeos-main <adeos-main@gna.org>
Subject: [Adeos-main] [PATCH 2/3] ipipe: Drop spurious irq_enter/exit from __ipipe_sync_stage
Date: Thu, 25 Nov 2010 17:38:45 +0100	[thread overview]
Message-ID: <4CEE9115.6000404@domain.hid> (raw)
In-Reply-To: <4CEE8FF0.6000704@domain.hid>

Invoking irq_enter/exit for root vIRQs is arch business (at least x86
needs to interleave it with exit code).

Signed-off-by: Jan Kiszka <jan.kiszka@domain.hid>
---
 kernel/ipipe/core.c |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/kernel/ipipe/core.c b/kernel/ipipe/core.c
index 756ad02..129113b 100644
--- a/kernel/ipipe/core.c
+++ b/kernel/ipipe/core.c
@@ -1240,11 +1240,9 @@ void __ipipe_sync_stage(void)
 		if (likely(ipd != ipipe_root_domain)) {
 			ipd->irqs[irq].handler(irq, ipd->irqs[irq].cookie);
 			__ipipe_run_irqtail(irq);
-		} else if (ipipe_virtual_irq_p(irq)) {
-			irq_enter();
+		} else if (ipipe_virtual_irq_p(irq))
 			__ipipe_do_root_virq(ipd, irq);
-			irq_exit();
-		} else
+		else
 			__ipipe_do_root_xirq(ipd, irq);
 
 		local_irq_disable_hw();
-- 
1.7.1


  parent reply	other threads:[~2010-11-25 16:38 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-25 16:33 [Adeos-main] [git pull] Updates for ipipe-2.6.36-noarch Jan Kiszka
2010-11-25 16:38 ` [Adeos-main] [PATCH 1/3] ipipe: Provide wrapper for IRQ mask/unmask at chip level Jan Kiszka
2010-11-25 16:38 ` Jan Kiszka [this message]
2010-11-25 16:38 ` [Adeos-main] [PATCH 3/3] ipipe: Provide __ipipe_spin_trylock_irq for !CONFIG_IPIPE Jan Kiszka
2011-01-18 17:13 ` [Adeos-main] [git pull] Updates for ipipe-2.6.36-noarch Philippe Gerum
2011-01-18 17:22   ` Jan Kiszka
2011-01-18 17:27     ` Philippe Gerum
2011-01-18 17:30       ` Jan Kiszka
2011-01-18 17:37         ` Gilles Chanteperdrix
2011-01-18 17:44           ` Jan Kiszka
2011-01-25 19:45   ` Philippe Gerum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CEE9115.6000404@domain.hid \
    --to=jan.kiszka@domain.hid \
    --cc=adeos-main@gna.org \
    --cc=rpm@xenomai.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.