From: Ben Greear <greearb@candelatech.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: John Linville <linville@tuxdriver.com>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/2] nl80211/cfg80211: extend mgmt-tx API for off-channel
Date: Thu, 25 Nov 2010 12:49:55 -0800 [thread overview]
Message-ID: <4CEECBF3.3070202@candelatech.com> (raw)
In-Reply-To: <1290708300.3770.4.camel@jlt3.sipsolutions.net>
On 11/25/2010 10:05 AM, Johannes Berg wrote:
> On Thu, 2010-11-25 at 09:00 -0800, Ben Greear wrote:
>> What are the units for DURATION? It seems the code is treating
>> that as jiffies, but surely user-space should specify in msecs
>> or similar and have the kernel do the conversion?
>
> This code isn't even using them at all, and the nl80211 API specifies
> milliseconds. Where do you see it look like jiffies?
Sorry, the code looks right, I was mis-reading this part from the
next patch:
static enum work_action __must_check
+ieee80211_offchannel_tx(struct ieee80211_work *wk)
+{
+ if (!wk->started) {
+ wk->timeout = jiffies + msecs_to_jiffies(wk->offchan_tx.wait);
>
> johannes
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2010-11-25 20:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-25 9:02 [PATCH 0/2] off-channel TX support Johannes Berg
2010-11-25 9:02 ` [PATCH 1/2] nl80211/cfg80211: extend mgmt-tx API for off-channel Johannes Berg
2010-11-25 17:00 ` Ben Greear
2010-11-25 18:05 ` Johannes Berg
2010-11-25 20:49 ` Ben Greear [this message]
2010-11-25 9:02 ` [PATCH 2/2] mac80211: implement off-channel mgmt TX Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CEECBF3.3070202@candelatech.com \
--to=greearb@candelatech.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.