From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH] call-volume: Minor coding style fix
Date: Fri, 26 Nov 2010 15:03:13 -0600 [thread overview]
Message-ID: <4CF02091.3020601@gmail.com> (raw)
In-Reply-To: <1290783465-5541-1-git-send-email-jeevaka.badrappan@elektrobit.com>
[-- Attachment #1: Type: text/plain, Size: 682 bytes --]
Hi Jeevaka,
On 11/26/2010 08:57 AM, Jeevaka Badrappan wrote:
> ---
> src/call-volume.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/src/call-volume.c b/src/call-volume.c
> index dd1be92..0accdf2 100644
> --- a/src/call-volume.c
> +++ b/src/call-volume.c
> @@ -114,7 +114,6 @@ static DBusMessage *cv_get_properties(DBusConnection *conn,
> dbus_bool_t muted;
>
> reply = dbus_message_new_method_return(msg);
> -
> if (!reply)
> return NULL;
>
Style wise this is actually OK, but if you really want to be
style-pedantic :) then this should be:
reply = ...
if (reply == NULL)
return NULL
Regards,
-Denis
next prev parent reply other threads:[~2010-11-26 21:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-26 14:57 [PATCH] call-volume: Minor coding style fix Jeevaka Badrappan
2010-11-26 21:03 ` Denis Kenzior [this message]
2010-11-26 21:21 ` Jeevaka Badrappan
2010-11-26 21:24 ` Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CF02091.3020601@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.