diff for duplicates of <4CF13AC4.3060508@gmail.com> diff --git a/a/1.txt b/N1/1.txt index 5b2514b..a80ed28 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -172,7 +172,8 @@ value 0 do you really need all that initializations to 'false'? > + .e_byte_clk = DSIM_PLL_OUT_DIV8, > + > + /* -> + * =====================> + * | P | M | S | MHz | +> + * =========================================== +> + * | P | M | S | MHz | > + * ------------------------------------------- > + * | 3 | 100 | 3 | 100 | > + * | 3 | 100 | 2 | 200 | @@ -426,7 +427,7 @@ Ditto. > +{ > + unsigned int reg; > + -> + WARN_ON(dsim = NULL); +> + WARN_ON(dsim == NULL); > + > + reg = readl(S5P_MIPI_CONTROL)& ~(1<< 0); > + reg |= (enable<< 0); @@ -446,7 +447,7 @@ since the addresses used are statically remapped. > +{ > + unsigned int reg; > + -> + WARN_ON(dsim = NULL); +> + WARN_ON(dsim == NULL); Issuing a warning when "dsim" is NULL and then crashing on a dereference of it seems rather pointless to me. But it might be just me. @@ -463,7 +464,7 @@ of it seems rather pointless to me. But it might be just me. > + > +int s5p_dsim_part_reset(struct dsim_global *dsim) > +{ -> + WARN_ON(dsim = NULL); +> + WARN_ON(dsim == NULL); > + > + writel(S5P_MIPI_M_RESETN, S5P_MIPI_PHY_CON0); > + @@ -474,7 +475,7 @@ of it seems rather pointless to me. But it might be just me. > + > +int s5p_dsim_init_d_phy(struct dsim_global *dsim) > +{ -> + WARN_ON(dsim = NULL); +> + WARN_ON(dsim == NULL); > + > + /** > + * DPHY and Master block must be enabled at the system initialization @@ -501,7 +502,7 @@ possible. > +{ > + int ret = -1; > + -> + WARN_ON(dsim = NULL); +> + WARN_ON(dsim == NULL); > + > + if (IS_ERR(p_mipi_1_1v) || IS_ERR(p_mipi_1_8v)) { > + dev_err(dsim->dev, "p_mipi_1_1v or p_mipi_1_8v is NULL.\n"); diff --git a/a/content_digest b/N1/content_digest index c3d98bb..9c6147d 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,7 +1,7 @@ "ref\01290496593-4927-1-git-send-email-inki.dae@samsung.com\0" - "From\0Sylwester Nawrocki <spnlinux@gmail.com>\0" - "Subject\0Re: [PATCH 3/4] S5PC110: add MIPI-DSI support for platform and machine.\0" - "Date\0Sat, 27 Nov 2010 17:07:16 +0000\0" + "From\0spnlinux@gmail.com (Sylwester Nawrocki)\0" + "Subject\0[PATCH 3/4] S5PC110: add MIPI-DSI support for platform and machine.\0" + "Date\0Sat, 27 Nov 2010 18:07:16 +0100\0" "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" @@ -179,7 +179,8 @@ "> +\t.e_byte_clk = DSIM_PLL_OUT_DIV8,\n" "> +\n" "> +\t/*\n" - "> +\t * =====================> +\t * | P | M | S | MHz |\n" + "> +\t * ===========================================\n" + "> +\t * | P | M | S | MHz |\n" "> +\t * -------------------------------------------\n" "> +\t * | 3 | 100 | 3 | 100 |\n" "> +\t * | 3 | 100 | 2 | 200 |\n" @@ -433,7 +434,7 @@ "> +{\n" "> +\tunsigned int reg;\n" "> +\n" - "> +\tWARN_ON(dsim = NULL);\n" + "> +\tWARN_ON(dsim == NULL);\n" "> +\n" "> +\treg = readl(S5P_MIPI_CONTROL)& ~(1<< 0);\n" "> +\treg |= (enable<< 0);\n" @@ -453,7 +454,7 @@ "> +{\n" "> +\tunsigned int reg;\n" "> +\n" - "> +\tWARN_ON(dsim = NULL);\n" + "> +\tWARN_ON(dsim == NULL);\n" "\n" "Issuing a warning when \"dsim\" is NULL and then crashing on a dereference \n" "of it seems rather pointless to me. But it might be just me.\n" @@ -470,7 +471,7 @@ "> +\n" "> +int s5p_dsim_part_reset(struct dsim_global *dsim)\n" "> +{\n" - "> +\tWARN_ON(dsim = NULL);\n" + "> +\tWARN_ON(dsim == NULL);\n" "> +\n" "> +\twritel(S5P_MIPI_M_RESETN, S5P_MIPI_PHY_CON0);\n" "> +\n" @@ -481,7 +482,7 @@ "> +\n" "> +int s5p_dsim_init_d_phy(struct dsim_global *dsim)\n" "> +{\n" - "> +\tWARN_ON(dsim = NULL);\n" + "> +\tWARN_ON(dsim == NULL);\n" "> +\n" "> +\t/**\n" "> +\t * DPHY and Master block must be enabled at the system initialization\n" @@ -508,7 +509,7 @@ "> +{\n" "> +\tint ret = -1;\n" "> +\n" - "> +\tWARN_ON(dsim = NULL);\n" + "> +\tWARN_ON(dsim == NULL);\n" "> +\n" "> +\tif (IS_ERR(p_mipi_1_1v) || IS_ERR(p_mipi_1_8v)) {\n" "> +\t\tdev_err(dsim->dev, \"p_mipi_1_1v or p_mipi_1_8v is NULL.\\n\");\n" @@ -579,4 +580,4 @@ "Regards,\n" Sylwester -4f3cca2184d4eec3cf0b283028120f18eca1ffd0f95647896f42d547c17c5399 +cbe45e94a8cfa31b4d43d6b8a6ee1b0700ac37d543943de7c525cbbdc6487a55
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.