From: Li Zefan <lizf@cn.fujitsu.com>
To: linux-btrfs@vger.kernel.org
Cc: Sage Weil <sage@newdream.net>
Subject: [PATCH 2/5] btrfs: Fix memory leak in a failure path
Date: Mon, 29 Nov 2010 16:03:04 +0800 [thread overview]
Message-ID: <4CF35E38.4020606@cn.fujitsu.com> (raw)
In-Reply-To: <4CF35E17.6050705@cn.fujitsu.com>
In btrfs_ioctl_snap_create(), vol_args_v2 is not freed if
copy_to_user() returns failure.
Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
---
fs/btrfs/ioctl.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c
index d3f1a60..ba437ad 100644
--- a/fs/btrfs/ioctl.c
+++ b/fs/btrfs/ioctl.c
@@ -976,7 +976,7 @@ static noinline int btrfs_ioctl_snap_create(struct file *file,
if (copy_to_user(arg +
offsetof(struct btrfs_ioctl_vol_args_v2,
transid), &transid, sizeof(transid)))
- return -EFAULT;
+ ret = -EFAULT;
}
out:
kfree(vol_args);
--
1.6.3
next prev parent reply other threads:[~2010-11-29 8:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-29 8:02 [PATCH 0/5] btrfs: Readonly snapshots Li Zefan
2010-11-29 8:02 ` [PATCH 1/5] btrfs: Make async snapshot ioctl more generic Li Zefan
2010-11-29 18:52 ` Goffredo Baroncelli
2010-11-30 1:13 ` Li Zefan
2010-11-29 19:28 ` Sage Weil
2010-12-07 19:04 ` Sage Weil
2010-12-08 1:09 ` Li Zefan
2010-11-29 8:03 ` Li Zefan [this message]
2010-11-29 8:03 ` [PATCH 3/5] btrfs: Add helper __setup_root_post() Li Zefan
2010-11-29 8:03 ` [PATCH 4/5] btrfs: Add readonly snapshots support Li Zefan
2010-11-29 8:03 ` [PATCH 5/5] btrfs: Add ioctl to set snapshot readonly/writable Li Zefan
2010-11-29 18:52 ` Goffredo Baroncelli
2010-11-30 7:03 ` Li Zefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CF35E38.4020606@cn.fujitsu.com \
--to=lizf@cn.fujitsu.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=sage@newdream.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.