From: Gerd Hoffmann <kraxel@redhat.com>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>
Subject: [Qemu-devel] Re: [RfC PATCH] spice: qmp windup: connection events & info command.
Date: Mon, 29 Nov 2010 12:02:45 +0100 [thread overview]
Message-ID: <4CF38855.90109@redhat.com> (raw)
In-Reply-To: <20101129100320.GA2528@redhat.com>
Hi,
>> Doesn't make that much sense IMHO as the both provide quite simliar
>> informations (i.e. "info spice" gives you a list of connections with
>> pretty much the same info provided by the events).
>
> If you are wanting to record/log incoming connections, then you
> can't use 'info spice' to get the details, because between the
> time of getting the event notification of the new client and
> calling 'info spice' to get the client details, the client can
> have disconnected. Thus all the info needs to be provided in the
> event, even if it is also available in 'info spice'. This is the
> same as with VNC events.
Sure. All the info is given in both cases, thats why there is quite
some code sharing ;) I'll go split the patch nevertheless, with the doc
updates added it indeed makes sense.
"info spice" can be used to figure the connections which did already
exist before management connected to qmp. Later on just processing the
events gives you all informations you need.
cheers,
Gerd
prev parent reply other threads:[~2010-11-29 11:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-11 12:49 [Qemu-devel] [RfC PATCH] spice: qmp windup: connection events & info command Gerd Hoffmann
2010-11-12 15:58 ` [Qemu-devel] " Luiz Capitulino
2010-11-25 11:42 ` Gerd Hoffmann
2010-11-25 13:57 ` Luiz Capitulino
[not found] ` <20101129100320.GA2528@redhat.com>
2010-11-29 11:02 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CF38855.90109@redhat.com \
--to=kraxel@redhat.com \
--cc=berrange@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.