From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=55836 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PN36D-0001IY-Sv for qemu-devel@nongnu.org; Mon, 29 Nov 2010 07:44:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PN36C-0004Rp-PI for qemu-devel@nongnu.org; Mon, 29 Nov 2010 07:44:53 -0500 Received: from goliath.siemens.de ([192.35.17.28]:24579) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PN36C-0004RU-Ge for qemu-devel@nongnu.org; Mon, 29 Nov 2010 07:44:52 -0500 Message-ID: <4CF3A042.80509@siemens.com> Date: Mon, 29 Nov 2010 13:44:50 +0100 From: Jan Kiszka MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] xen: Restrict build to x86 targets References: <4CF27C6D.9000401@web.de> <5C53BA9F-A1B7-4CAB-BFFC-F6111021A292@suse.de> <4CF39CE5.9090204@siemens.com> <521B6BE1-61B7-4650-A4B2-541C7C45734B@suse.de> In-Reply-To: <521B6BE1-61B7-4650-A4B2-541C7C45734B@suse.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: qemu-devel Am 29.11.2010 13:40, Alexander Graf wrote: > > On 29.11.2010, at 13:30, Jan Kiszka wrote: > >> Am 29.11.2010 13:24, Alexander Graf wrote: >>> >>> On 28.11.2010, at 16:59, Jan Kiszka wrote: >>> >>>> From: Jan Kiszka >>>> >>>> Xen target bits in qemu are intended for x86. Let the build system >>>> reflect this and avoid useless building/linking for other targets. >>> >>> Not sure I understand the split. Xen is x86 only, yes. But why split it into host and target? Target usually defines the guest. The piece you marked as _HOST are target specific. >> >> At least so far, the HOST part is build once for all targets into the >> host backend library. As this step injected CONFIG_XEN into all target >> builds, even non-x86 targets built xen_machine_pv and xen_domainbuild. >> That's addressed by the patch. > > I still don't understand the need for that split. Enable Xen and build some non-x86 targets, then you see the need. > The device drivers should be built only once, as do the xen_machine_pv parts. Both are useless on non-x86. CONFIG_XEN should simply always be a target specific option. Maybe the split-up between the "generic" host-side interfaces and xen_machine_pv/xen_domainbuild is the problem. You know the dependencies better than me, maybe you find a better fix. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux