Re: [RFC 2/2] wl12xx: Stop BA session event from device

[Shahar Levi <shahar_levi@ti.com>]

On 11/29/2010 02:58 PM, Luciano Coelho wrote:
> On Mon, 2010-11-29 at 14:55 +0200, ext Shahar Levi wrote:
>> On 11/29/2010 02:53 PM, Luciano Coelho wrote:
>>> On Thu, 2010-11-25 at 16:39 +0200, ext Shahar Levi wrote:
>>>> Adding new event that close RX BA session in case of periodic BT activity
>>>> limiting WLAN activity.
>>>>
>>>> Signed-off-by: Shahar Levi<shahar_levi@ti.com>
>>>> ---
>>>
>>> [...]
>>>
>>>> diff --git a/drivers/net/wireless/wl12xx/event.c b/drivers/net/wireless/wl12xx/event.c
>>>> index 9815b7b..7cbeb2b 100644
>>>> --- a/drivers/net/wireless/wl12xx/event.c
>>>> +++ b/drivers/net/wireless/wl12xx/event.c
>>>> @@ -174,6 +174,25 @@ static void wl1271_event_rssi_trigger(struct wl1271 *wl,
>>>>    	wl->last_rssi_event = event;
>>>>    }
>>>>
>>>> +static void wl1271_event_ba_rx_constraint(struct wl1271 *wl,
>>>> +					  struct event_mailbox *mbox)
>>>> +{
>>>> +	u8 tid_index = 0;
>>>> +
>>>> +	wl1271_debug(DEBUG_EVENT, "BA RX constraint event. ba_allowed = %d",
>>>> +		     mbox->ba_allowed);
>>>> +
>>>> +	wl->ba_allowed = mbox->ba_allowed;
>>>> +
>>>> +	if (!wl->ba_rx_bitmap)
>>>> +		return;
>>>> +
>>>> +	for (tid_index = 0; tid_index<   CONF_TX_MAX_TID_COUNT; ++tid_index)
>>>
>>> Please use the more classic tid_index++ instead.
>> OK, will be fix on v2.
>
> This is really nitpicking now, but if you change tid_index to i instead,
> you won't need two lines for the call to ieee80211_stop_rx_ba_session(),
> because it will fit in one line. :P
>
;-)
no problem. will do.