Re: [PATCH 1/5] text-telephony: add public header

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 792 bytes --]

Hi Waldo,

On 11/27/2010 03:04 PM, Bastian, Waldo wrote:
>>> +	void (*remove)(struct ofono_ctm *tt);
>>> +	void (*query_tty)(struct ofono_ctm *tt,
>>> +				ofono_ctm_query_cb_t cb,
>>> +				void *data);
>>> +	void (*set_tty)(struct ofono_ctm *tt,
>>> +				int enable,
>>
>> I also changed this to ofono_bool_t enable
> 
> Fyi, I noticed that radio-settings.h has this as an int as well:
> 
> 67         void (*set_fast_dormancy)(struct ofono_radio_settings *rs,
> 68                                 int enable,
> 69                                 ofono_radio_settings_fast_dormancy_set_cb_t,
> 70                                 void *data);
> 
> The query callback otoh uses ofono_bool_t.
> 

Thanks for pointing this out.  It has now been fixed.

Regards,
-Denis