From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=37474 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PN4hy-0003xJ-Rv for qemu-devel@nongnu.org; Mon, 29 Nov 2010 09:28:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PN4hw-0001yf-RN for qemu-devel@nongnu.org; Mon, 29 Nov 2010 09:27:58 -0500 Received: from thoth.sbs.de ([192.35.17.2]:16753) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PN4hw-0001y9-Fh for qemu-devel@nongnu.org; Mon, 29 Nov 2010 09:27:56 -0500 Message-ID: <4CF3B869.4080001@siemens.com> Date: Mon, 29 Nov 2010 15:27:53 +0100 From: Jan Kiszka MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] xen: Restrict build to x86 targets References: <4CF27C6D.9000401@web.de> <5C53BA9F-A1B7-4CAB-BFFC-F6111021A292@suse.de> <4CF39CE5.9090204@siemens.com> <521B6BE1-61B7-4650-A4B2-541C7C45734B@suse.de> <4CF3A042.80509@siemens.com> <8C89D18A-502C-4458-83DE-7B393546547D@suse.de> In-Reply-To: <8C89D18A-502C-4458-83DE-7B393546547D@suse.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: qemu-devel Am 29.11.2010 15:15, Alexander Graf wrote: > > On 29.11.2010, at 13:44, Jan Kiszka wrote: > >> Am 29.11.2010 13:40, Alexander Graf wrote: >>> >>> On 29.11.2010, at 13:30, Jan Kiszka wrote: >>> >>>> Am 29.11.2010 13:24, Alexander Graf wrote: >>>>> >>>>> On 28.11.2010, at 16:59, Jan Kiszka wrote: >>>>> >>>>>> From: Jan Kiszka >>>>>> >>>>>> Xen target bits in qemu are intended for x86. Let the build system >>>>>> reflect this and avoid useless building/linking for other targets. >>>>> >>>>> Not sure I understand the split. Xen is x86 only, yes. But why split it into host and target? Target usually defines the guest. The piece you marked as _HOST are target specific. >>>> >>>> At least so far, the HOST part is build once for all targets into the >>>> host backend library. As this step injected CONFIG_XEN into all target >>>> builds, even non-x86 targets built xen_machine_pv and xen_domainbuild. >>>> That's addressed by the patch. >>> >>> I still don't understand the need for that split. >> >> Enable Xen and build some non-x86 targets, then you see the need. >> >>> The device drivers should be built only once, as do the xen_machine_pv parts. Both are useless on non-x86. CONFIG_XEN should simply always be a target specific option. >> >> Maybe the split-up between the "generic" host-side interfaces and >> xen_machine_pv/xen_domainbuild is the problem. You know the dependencies >> better than me, maybe you find a better fix. > > Should be enough to just replace obj-$(CONFIG_XEN) by obj-i386-$(CONFIG_XEN). Indeed (as long as qemu's xen remains x86-only). > Unless it's very urgent, please wait with this patch until qemu-dm and xenner are in. It's pretty suboptimal to have 3 patches flying around that hit the exact same code spot :). It isn't urgent. If patches series refactor the stuff and fix the dependency, I'm happy to wait for them. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux