From: Nishanth Menon <nm@ti.com>
To: Arno Steffen <arno.steffen@googlemail.com>
Cc: linux-omap@vger.kernel.org, "tony@atomide.com" <tony@atomide.com>
Subject: Re: [PATCH] OMAP3_IVA_MASK should use OMAP3_IVA_SHIFT instead of OMAP3_SGX_SHIFT
Date: Mon, 29 Nov 2010 08:29:57 -0600 [thread overview]
Message-ID: <4CF3B8E5.8040109@ti.com> (raw)
In-Reply-To: <AANLkTi=rVpQWnRmzw2XF3TzoQW6E9fHLKfrdZUi8-cJo@mail.gmail.com>
Arno Steffen had written, on 11/26/2010 05:41 AM, the following:
minor comment:
$subject could be the commit message probably.. and a smaller subject
like OMAP3: fix typo in OMAP3_IVA_MASK could be used
otherwise, looks good to me.
> Signed-off-by: Arno Steffen <arno.steffen@googlemail.com>
> ---
> arch/arm/mach-omap2/control.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/control.h b/arch/arm/mach-omap2/control.h
> index b6c6b7c..5325297 100644
> --- a/arch/arm/mach-omap2/control.h
> +++ b/arch/arm/mach-omap2/control.h
> @@ -309,7 +309,7 @@
> #define FEAT_SGX_NONE 2
>
> #define OMAP3_IVA_SHIFT 12
> -#define OMAP3_IVA_MASK (1 << OMAP3_SGX_SHIFT)
> +#define OMAP3_IVA_MASK (1 << OMAP3_IVA_SHIFT)
> #define FEAT_IVA 0
> #define FEAT_IVA_NONE 1
>
--
Regards,
Nishanth Menon
next prev parent reply other threads:[~2010-11-29 14:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-26 11:41 [PATCH] OMAP3_IVA_MASK should use OMAP3_IVA_SHIFT instead of OMAP3_SGX_SHIFT Arno Steffen
2010-11-29 14:29 ` Nishanth Menon [this message]
2010-11-29 21:25 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CF3B8E5.8040109@ti.com \
--to=nm@ti.com \
--cc=arno.steffen@googlemail.com \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.