From: Fabio Estevam <fabio.estevam@freescale.com>
To: <dedekind1@gmail.com>
Cc: Estevam Fabio-R49496 <r49496@freescale.com>,
linux-mtd@lists.infradead.org, dwmw2@infradead.org,
u.kleine-koenig@pengutronix.de
Subject: Re: [PATCH] mtd: mxc_nand: Fix warning on nr_parts unused variable
Date: Mon, 29 Nov 2010 13:10:06 -0200 [thread overview]
Message-ID: <4CF3C24E.2060801@freescale.com> (raw)
In-Reply-To: <1291042287.2141.12.camel@koala>
On 11/29/2010 12:51 PM, Artem Bityutskiy wrote:
> On Tue, 2010-11-23 at 17:02 -0200, Fabio Estevam wrote:
> > If CONFIG_MTD_PARTITIONS is not selected, then the following warning
> is generated:
> >
> > CC drivers/mtd/nand/mxc_nand.o
> > drivers/mtd/nand/mxc_nand.c: In function 'mxcnd_probe':
> > drivers/mtd/nand/mxc_nand.c:1014: warning: unused variable 'nr_parts'
> >
> > Fix it by marking nr_parts as __maybe_unused.
> >
> > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
>
> I'm curious, do you really use MTD without CONFIG_MTD_PARTITIONS ? Or
> you found just random warning? I'm asking because I believed this config
> option has to be killed, because it causes more harm in form of mess,
> than good.
I was using it without CONFIG_MTD_PARTITIONS because first I was trying
to get the NAND to be detected only.
> Anyway, putting this to my l2-mtd-2.6.git, thanks.
Thanks,
Fabio Estevam
prev parent reply other threads:[~2010-11-29 15:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-23 19:02 [PATCH] mtd: mxc_nand: Fix warning on nr_parts unused variable Fabio Estevam
2010-11-29 14:51 ` Artem Bityutskiy
2010-11-29 15:10 ` Fabio Estevam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CF3C24E.2060801@freescale.com \
--to=fabio.estevam@freescale.com \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=r49496@freescale.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.