From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============7716950320097909824==" MIME-Version: 1.0 From: Denis Kenzior Subject: Re: [PATCH 2/9] drivers: explicitly compare pointers to NULL Date: Mon, 29 Nov 2010 14:48:23 -0600 Message-ID: <4CF41197.2090105@gmail.com> In-Reply-To: <1290886743-24561-2-git-send-email-lucas.demarchi@profusion.mobi> List-Id: To: ofono@ofono.org --===============7716950320097909824== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On 11/27/2010 01:38 PM, Lucas De Marchi wrote: > This patch was generated by the following semantic patch > (http://coccinelle.lip6.fr/) > = > // > @fix disable is_null,isnt_null1@ > expression *E; > @@ > = > - !E > + E =3D=3D NULL > // > --- > drivers/atmodem/atutil.c | 2 +- > drivers/atmodem/atutil.h | 2 +- > drivers/atmodem/call-barring.c | 6 ++-- > drivers/atmodem/call-forwarding.c | 4 +- > drivers/atmodem/call-meter.c | 14 ++++++------ > drivers/atmodem/call-settings.c | 14 ++++++------ > drivers/atmodem/call-volume.c | 4 +- > drivers/atmodem/cbs.c | 6 ++-- > drivers/atmodem/devinfo.c | 8 +++--- > drivers/atmodem/gprs-context.c | 2 +- > drivers/atmodem/gprs.c | 6 ++-- > drivers/atmodem/network-registration.c | 18 ++++++++-------- > drivers/atmodem/phonebook.c | 4 +- > drivers/atmodem/sim-poll.c | 2 +- > drivers/atmodem/sim.c | 32 +++++++++++++++----------= ----- > drivers/atmodem/sms.c | 12 +++++----- > drivers/atmodem/stk.c | 4 +- > drivers/atmodem/ussd.c | 6 ++-- > drivers/atmodem/voicecall.c | 24 +++++++++++----------- > drivers/calypsomodem/stk.c | 6 ++-- > drivers/calypsomodem/voicecall.c | 6 ++-- > drivers/hfpmodem/call-volume.c | 4 +- > drivers/hfpmodem/network-registration.c | 6 ++-- > drivers/hfpmodem/voicecall.c | 28 +++++++++++++------------- > drivers/hsomodem/gprs-context.c | 4 +- > drivers/hsomodem/radio-settings.c | 2 +- > drivers/huaweimodem/audio-settings.c | 2 +- > drivers/huaweimodem/gprs-context.c | 6 ++-- > drivers/huaweimodem/voicecall.c | 8 +++--- > drivers/ifxmodem/audio-settings.c | 2 +- > drivers/ifxmodem/gprs-context.c | 8 +++--- > drivers/ifxmodem/radio-settings.c | 2 +- > drivers/ifxmodem/stk.c | 6 ++-- > drivers/ifxmodem/voicecall.c | 18 ++++++++-------- > drivers/isimodem/audio-settings.c | 6 ++-- > drivers/isimodem/call-barring.c | 12 +++++----- > drivers/isimodem/call-forwarding.c | 12 +++++----- > drivers/isimodem/call-meter.c | 4 +- > drivers/isimodem/call-settings.c | 10 ++++---- > drivers/isimodem/cbs.c | 9 +++---- > drivers/isimodem/devinfo.c | 12 +++++----- > drivers/isimodem/gprs-context.c | 19 +++++++---------- > drivers/isimodem/gprs.c | 10 ++++---- > drivers/isimodem/infoserver.c | 4 +- > drivers/isimodem/network-registration.c | 22 +++++++++----------- > drivers/isimodem/phonebook.c | 10 ++++---- > drivers/isimodem/radio-settings.c | 10 ++++---- > drivers/isimodem/sim.c | 12 +++++----- > drivers/isimodem/sms.c | 17 +++++++-------- > drivers/isimodem/ssn.c | 6 ++-- > drivers/isimodem/ussd.c | 10 ++++---- > drivers/isimodem/voicecall.c | 12 ++++------ > drivers/mbmmodem/gprs-context.c | 6 ++-- > drivers/mbmmodem/stk.c | 6 ++-- > drivers/nwmodem/radio-settings.c | 2 +- > drivers/stemodem/gprs-context.c | 14 ++++++------ > drivers/stemodem/radio-settings.c | 2 +- > drivers/stemodem/voicecall.c | 16 +++++++------- > 58 files changed, 256 insertions(+), 265 deletions(-) > = Patch has been applied. However, I had to amend the patch since it introduced style issues (particularly lines over 80 characters). Is there any way to preserve the max line width in the future? Otherwise you might have to amend them by hand... Regards, -Denis --===============7716950320097909824==--