From: Bian Naimeng <biannm@cn.fujitsu.com>
To: Garrett Cooper <yanegomi@gmail.com>
Cc: ltp-list@lists.sourceforge.net
Subject: [LTP] [POSIX[PATCH]Fix the bug of generate-makefiles.sh
Date: Tue, 30 Nov 2010 16:14:39 +0800 [thread overview]
Message-ID: <4CF4B26F.3030000@cn.fujitsu.com> (raw)
Script generate-makefiles.sh has a bug, it can cause run.sh miss some tests.
For exemple, this is the makefile of conformance/interfaces/sched_getparam:
INSTALL_TARGETS+= 4-1.run-test 5-1.sh
MAKE_TARGETS+= 4-1.run-test
INSTALL_TARGETS+= 2-1.run-test 1-1.run-test 3-1.run-test 6-1.run-test
MAKE_TARGETS+= 2-1.run-test 1-1.run-test 3-1.run-test 6-1.run-test
... snip ...
run.sh:
@echo '#/bin/sh' > $@
@echo "$(top_srcdir)/bin/run-tests.sh $(subdir) 4-1.run-test 5-1.sh" >> $@
@chmod +x run.sh
So what about the following patch?
----------------------------------------------------------------------------------
If there are some source files at the child directory, generate_makefile will
be invoked twice, then run.sh will miss some tests.
Signed-off-by: Bian Naimeng <biannm@cn.fujitsu.com>
---
.../scripts/generate-makefiles.sh | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/testcases/open_posix_testsuite/scripts/generate-makefiles.sh b/testcases/open_posix_testsuite/scripts/generate-makefiles.sh
index 536d407..ed6406f 100755
--- a/testcases/open_posix_testsuite/scripts/generate-makefiles.sh
+++ b/testcases/open_posix_testsuite/scripts/generate-makefiles.sh
@@ -152,11 +152,11 @@ EOF
fi
- if [ "$tests" != "" ] && ! grep -q '^run.sh' "$makefile.3"; then
+ if ! grep -q '^run.sh' "$makefile.3"; then
cat >> "$makefile.3" <<EOF
run.sh:
@echo '#/bin/sh' > \$@
- @echo "\$(top_srcdir)/bin/run-tests.sh \$(subdir) $tests" >> \$@
+ @echo "\$(top_srcdir)/bin/run-tests.sh \$(subdir) \$(INSTALL_TARGETS)" >> \$@
@chmod +x run.sh
EOF
--
1.7.0.4
--
Regards
Bian Naimeng
------------------------------------------------------------------------------
Increase Visibility of Your 3D Game App & Earn a Chance To Win $500!
Tap into the largest installed PC base & get more eyes on your game by
optimizing for Intel(R) Graphics Technology. Get started today with the
Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs.
http://p.sf.net/sfu/intelisp-dev2dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next reply other threads:[~2010-11-30 8:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-30 8:14 Bian Naimeng [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-12-21 7:47 [LTP] [POSIX][PATCH]Fix the bug of generate-makefiles.sh Bian Naimeng
2010-12-21 8:10 ` Garrett Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CF4B26F.3030000@cn.fujitsu.com \
--to=biannm@cn.fujitsu.com \
--cc=ltp-list@lists.sourceforge.net \
--cc=yanegomi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.