From: Anand Gadiyar <gadiyar@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: linux-usb@vger.kernel.org, linux-omap@vger.kernel.org,
Greg KH <gregkh@suse.de>
Subject: Re: [PATCH v2 2/4] arm: omap4: usb: add platform init code for EHCI
Date: Wed, 01 Dec 2010 03:36:30 +0530 [thread overview]
Message-ID: <4CF57566.2060800@ti.com> (raw)
In-Reply-To: <20101130214045.GA17222@atomide.com>
On 12/1/2010 3:10 AM, Tony Lindgren wrote:
> * Anand Gadiyar <gadiyar@ti.com> [101129 09:16]:
>> - Add platform init code for EHCI on OMAP4
>> - Add pad configuration for PHY and TLL modes
>>
>> Signed-off-by: Anand Gadiyar <gadiyar@ti.com>
>
> Looks OK to me. You might want to check if all these signals
> are unique though and do not have alternate paths.
>
> Acked-by: Tony Lindgren <tony@atomide.com>
I've checked these manually - for EHCI, all signals are unique
and come out on exactly one pad. With OHCI though, there are
alternates for 3 signals of one port.
Also, with the mux framework, it tells us if there are
duplicates and the framework cannot identify the pad from
the signal name alone.
- Anand
next prev parent reply other threads:[~2010-11-30 22:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-29 17:26 [PATCH v2 0/4] arm: omap4: Add support for EHCI Anand Gadiyar
2010-11-29 17:26 ` [PATCH v2 1/4] arm: omap4: add USBHOST and related base addresses Anand Gadiyar
2010-11-29 17:26 ` [PATCH v2 2/4] arm: omap4: usb: add platform init code for EHCI Anand Gadiyar
2010-11-30 21:40 ` Tony Lindgren
2010-11-30 22:06 ` Anand Gadiyar [this message]
[not found] ` <4CF57566.2060800-l0cyMroinI0@public.gmane.org>
2010-12-06 19:10 ` Tony Lindgren
[not found] ` <1291051572-24084-1-git-send-email-gadiyar-l0cyMroinI0@public.gmane.org>
2010-11-29 17:26 ` [PATCH v2 3/4] arm: omap4: select USB_ARCH_HAS_EHCI Anand Gadiyar
2010-11-29 17:26 ` [PATCH v2 4/4] omap4: 4430sdp: enable the ehci port on 4430SDP Anand Gadiyar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CF57566.2060800@ti.com \
--to=gadiyar@ti.com \
--cc=gregkh@suse.de \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.