From: Randy Dunlap <randy.dunlap@oracle.com>
To: Andres Salomon <dilinger@queued.net>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cs5535-mfd: fix warning on x86-64 (v2)
Date: Tue, 30 Nov 2010 14:36:42 -0800 [thread overview]
Message-ID: <4CF57C7A.5060905@oracle.com> (raw)
In-Reply-To: <20101130135439.2e293d65@queued.net>
On 11/30/10 13:54, Andres Salomon wrote:
>
> ARRAY_SIZE() returns size_t; use %zu instead of %d so that we don't
> get warnings on x86-64.
>
> Signed-off-by: Andres Salomon <dilinger@queued.net>
Acked-by: Randy Dunlap <randy.dunlap@oracle.com>
Glad you used %zu instead of %zd.
> ---
> drivers/mfd/cs5535-mfd.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mfd/cs5535-mfd.c b/drivers/mfd/cs5535-mfd.c
> index b141ca7..59ca6f1 100644
> --- a/drivers/mfd/cs5535-mfd.c
> +++ b/drivers/mfd/cs5535-mfd.c
> @@ -103,7 +103,7 @@ static int __devinit cs5535_mfd_probe(struct pci_dev *pdev,
> goto err_disable;
> }
>
> - dev_info(&pdev->dev, "%d devices registered.\n",
> + dev_info(&pdev->dev, "%zu devices registered.\n",
> ARRAY_SIZE(cs5535_mfd_cells));
>
> return 0;
--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
next prev parent reply other threads:[~2010-11-30 22:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-29 0:52 linux-next: build warning after merge of the mfd tree Stephen Rothwell
2010-11-30 4:44 ` [PATCH] cs5535-mfd: fix warning on x86-64 Andres Salomon
2010-11-30 10:01 ` Samuel Ortiz
2010-12-07 18:38 ` Andres Salomon
2010-12-09 11:49 ` Samuel Ortiz
2010-11-30 18:22 ` Randy Dunlap
2010-11-30 21:44 ` Andres Salomon
2010-11-30 21:54 ` [PATCH] cs5535-mfd: fix warning on x86-64 (v2) Andres Salomon
2010-11-30 22:36 ` Randy Dunlap [this message]
2010-11-30 10:02 ` linux-next: build warning after merge of the mfd tree Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CF57C7A.5060905@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=dilinger@queued.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.