From: Weidong Han <weidong.han@intel.com>
To: Keir Fraser <keir@xen.org>
Cc: "Zhang, Yang Z" <yang.z.zhang@intel.com>,
Sander Eikelenboom <linux@eikelenboom.it>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
Jan Beulich <JBeulich@novell.com>
Subject: Re: RE: kernel panic when enable x2apic
Date: Wed, 01 Dec 2010 08:42:50 +0800 [thread overview]
Message-ID: <4CF59A0A.5040400@intel.com> (raw)
In-Reply-To: <C91A9347.B7D7%keir@xen.org>
Keir Fraser wrote:
> On 30/11/2010 09:23, "Keir Fraser" <keir@xen.org> wrote:
>
>
>>> The obvious solution is to remove
>>> boot_cpu_data.x86_capability[4] = cpuid_ecx(1) in start_vmx. It indeed
>>> works with the change. I will send out the patch after more tests.
>>>
>> Yes, the write to x86_capability is totally unnecessary. There is a similar
>> pointless one in SVM code -- in fact they don't even manage to write to the
>> correct array element of x86_capability[]!
>>
>> Removing both writes to x86_capability[] would be an appropriate fix for 4.0
>> branch as well.
>>
>
> I applied a fix to xen-unstable and xen-4.0-testing. Eyeballing plus a quick
> test convinces me it is absolutely fine. I credited you in the changeset
> comment, I hope that's okay.
>
>
Great!
Regards,
Weidong
prev parent reply other threads:[~2010-12-01 0:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-17 8:59 kernel panic when enable x2apic Zhang, Yang Z
2010-11-17 9:41 ` Jan Beulich
2010-11-17 13:16 ` Zhang, Yang Z
2010-11-17 16:23 ` Jan Beulich
2010-11-18 4:53 ` Zhang, Yang Z
2010-11-19 10:17 ` Jan Beulich
2010-11-19 10:40 ` Sander Eikelenboom
2010-11-19 11:08 ` Jan Beulich
2010-11-30 0:58 ` Zhang, Yang Z
2010-11-30 8:50 ` Weidong Han
2010-11-30 9:23 ` Keir Fraser
2010-11-30 11:40 ` Keir Fraser
2010-12-01 0:42 ` Weidong Han [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CF59A0A.5040400@intel.com \
--to=weidong.han@intel.com \
--cc=JBeulich@novell.com \
--cc=keir@xen.org \
--cc=linux@eikelenboom.it \
--cc=xen-devel@lists.xensource.com \
--cc=yang.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.