From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hidetoshi Seto Subject: Re: [Qemu-devel] Re: [PATCH v5] virtio-9p: fix build on !CONFIG_UTIMENSAT Date: Wed, 01 Dec 2010 10:16:15 +0900 Message-ID: <4CF5A1DF.3050808@jp.fujitsu.com> References: <4CEC7A92.3080302@jp.fujitsu.com> <4CECC642.8090404@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Cc: Blue Swirl , "kvm@vger.kernel.org" , Philipp Hahn , "Hao, Xudong" , "qemu-devel@nongnu.org" , Chris Wright , "M. Mohan Kumar" , Avi Kivity To: Jes Sorensen Return-path: Received: from fgwmail6.fujitsu.co.jp ([192.51.44.36]:47593 "EHLO fgwmail6.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752438Ab0LABQ4 (ORCPT ); Tue, 30 Nov 2010 20:16:56 -0500 Received: from m1.gw.fujitsu.co.jp ([10.0.50.71]) by fgwmail6.fujitsu.co.jp (Fujitsu Gateway) with ESMTP id oB11GsON003677 for (envelope-from seto.hidetoshi@jp.fujitsu.com); Wed, 1 Dec 2010 10:16:54 +0900 Received: from smail (m1 [127.0.0.1]) by outgoing.m1.gw.fujitsu.co.jp (Postfix) with ESMTP id 0FB1745DE5C for ; Wed, 1 Dec 2010 10:16:54 +0900 (JST) Received: from s1.gw.fujitsu.co.jp (s1.gw.fujitsu.co.jp [10.0.50.91]) by m1.gw.fujitsu.co.jp (Postfix) with ESMTP id E53AA45DE58 for ; Wed, 1 Dec 2010 10:16:53 +0900 (JST) Received: from s1.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s1.gw.fujitsu.co.jp (Postfix) with ESMTP id D9603E38002 for ; Wed, 1 Dec 2010 10:16:53 +0900 (JST) Received: from ml13.s.css.fujitsu.com (ml13.s.css.fujitsu.com [10.249.87.103]) by s1.gw.fujitsu.co.jp (Postfix) with ESMTP id 9CEC0E08002 for ; Wed, 1 Dec 2010 10:16:53 +0900 (JST) In-Reply-To: <4CECC642.8090404@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Ping. Maintainers, please tell me if still something is required for this patch before applying it. Thanks, H.Seto (2010/11/24 17:01), Jes Sorensen wrote: > On 11/24/10 03:38, Hidetoshi Seto wrote: >> This patch introduce a fallback mechanism for old systems that do not >> support utimensat(). This fix build failure with following warnings: >> >> hw/virtio-9p-local.c: In function 'local_utimensat': >> hw/virtio-9p-local.c:479: warning: implicit declaration of function 'utimensat' >> hw/virtio-9p-local.c:479: warning: nested extern declaration of 'utimensat' >> >> and: >> >> hw/virtio-9p.c: In function 'v9fs_setattr_post_chmod': >> hw/virtio-9p.c:1410: error: 'UTIME_NOW' undeclared (first use in this function) >> hw/virtio-9p.c:1410: error: (Each undeclared identifier is reported only once >> hw/virtio-9p.c:1410: error: for each function it appears in.) >> hw/virtio-9p.c:1413: error: 'UTIME_OMIT' undeclared (first use in this function) >> hw/virtio-9p.c: In function 'v9fs_wstat_post_chmod': >> hw/virtio-9p.c:2905: error: 'UTIME_OMIT' undeclared (first use in this function) >> >> [NOTE: At this time virtio-9p is only user of utimensat(), and is available >> only when host is linux and CONFIG_VIRTFS is defined. So there are >> no similar warning for win32. Please provide a wrapper for win32 in >> oslib-win32.c if new user really requires it.] >> >> v5: >> - Allow fallback on runtime >> - Move qemu_utimensat() to oslib-posix.c >> - Rebased on latest qemu.git >> v4: >> - Use tv_now.tv_usec >> v3: >> - Use better alternative handling for UTIME_NOW/OMIT >> - Move qemu_utimensat() to cutils.c >> V2: >> - Introduce qemu_utimensat() >> >> Acked-by: Chris Wright >> Acked-by: M. Mohan Kumar >> Signed-off-by: Hidetoshi Seto >> --- >> hw/virtio-9p-local.c | 4 ++-- >> oslib-posix.c | 48 ++++++++++++++++++++++++++++++++++++++++++++++++ >> qemu-os-posix.h | 12 ++++++++++++ >> 3 files changed, 62 insertions(+), 2 deletions(-) > > Hi Hidetoshi, > > This looks good to me! > > Acked-by: Jes Sorensen > > Cheers, > Jes From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=35872 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PNdFO-0002L5-Mv for qemu-devel@nongnu.org; Tue, 30 Nov 2010 22:20:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PNbJd-00026k-I9 for qemu-devel@nongnu.org; Tue, 30 Nov 2010 20:17:02 -0500 Received: from fgwmail5.fujitsu.co.jp ([192.51.44.35]:33307) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PNbJc-0001l6-UD for qemu-devel@nongnu.org; Tue, 30 Nov 2010 20:17:01 -0500 Received: from m1.gw.fujitsu.co.jp ([10.0.50.71]) by fgwmail5.fujitsu.co.jp (Fujitsu Gateway) with ESMTP id oB11Gsbu004707 for (envelope-from seto.hidetoshi@jp.fujitsu.com); Wed, 1 Dec 2010 10:16:54 +0900 Received: from smail (m1 [127.0.0.1]) by outgoing.m1.gw.fujitsu.co.jp (Postfix) with ESMTP id 08ECC45DE5A for ; Wed, 1 Dec 2010 10:16:54 +0900 (JST) Received: from s1.gw.fujitsu.co.jp (s1.gw.fujitsu.co.jp [10.0.50.91]) by m1.gw.fujitsu.co.jp (Postfix) with ESMTP id DAE0C45DE56 for ; Wed, 1 Dec 2010 10:16:53 +0900 (JST) Received: from s1.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s1.gw.fujitsu.co.jp (Postfix) with ESMTP id CD096E38001 for ; Wed, 1 Dec 2010 10:16:53 +0900 (JST) Received: from ml13.s.css.fujitsu.com (ml13.s.css.fujitsu.com [10.249.87.103]) by s1.gw.fujitsu.co.jp (Postfix) with ESMTP id 99D90E08001 for ; Wed, 1 Dec 2010 10:16:53 +0900 (JST) Message-ID: <4CF5A1DF.3050808@jp.fujitsu.com> Date: Wed, 01 Dec 2010 10:16:15 +0900 From: Hidetoshi Seto MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [PATCH v5] virtio-9p: fix build on !CONFIG_UTIMENSAT References: <4CEC7A92.3080302@jp.fujitsu.com> <4CECC642.8090404@redhat.com> In-Reply-To: <4CECC642.8090404@redhat.com> Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jes Sorensen Cc: Chris Wright , "kvm@vger.kernel.org" , Philipp Hahn , "Hao, Xudong" , "qemu-devel@nongnu.org" , Blue Swirl , "M. Mohan Kumar" , Avi Kivity Ping. Maintainers, please tell me if still something is required for this patch before applying it. Thanks, H.Seto (2010/11/24 17:01), Jes Sorensen wrote: > On 11/24/10 03:38, Hidetoshi Seto wrote: >> This patch introduce a fallback mechanism for old systems that do not >> support utimensat(). This fix build failure with following warnings: >> >> hw/virtio-9p-local.c: In function 'local_utimensat': >> hw/virtio-9p-local.c:479: warning: implicit declaration of function 'utimensat' >> hw/virtio-9p-local.c:479: warning: nested extern declaration of 'utimensat' >> >> and: >> >> hw/virtio-9p.c: In function 'v9fs_setattr_post_chmod': >> hw/virtio-9p.c:1410: error: 'UTIME_NOW' undeclared (first use in this function) >> hw/virtio-9p.c:1410: error: (Each undeclared identifier is reported only once >> hw/virtio-9p.c:1410: error: for each function it appears in.) >> hw/virtio-9p.c:1413: error: 'UTIME_OMIT' undeclared (first use in this function) >> hw/virtio-9p.c: In function 'v9fs_wstat_post_chmod': >> hw/virtio-9p.c:2905: error: 'UTIME_OMIT' undeclared (first use in this function) >> >> [NOTE: At this time virtio-9p is only user of utimensat(), and is available >> only when host is linux and CONFIG_VIRTFS is defined. So there are >> no similar warning for win32. Please provide a wrapper for win32 in >> oslib-win32.c if new user really requires it.] >> >> v5: >> - Allow fallback on runtime >> - Move qemu_utimensat() to oslib-posix.c >> - Rebased on latest qemu.git >> v4: >> - Use tv_now.tv_usec >> v3: >> - Use better alternative handling for UTIME_NOW/OMIT >> - Move qemu_utimensat() to cutils.c >> V2: >> - Introduce qemu_utimensat() >> >> Acked-by: Chris Wright >> Acked-by: M. Mohan Kumar >> Signed-off-by: Hidetoshi Seto >> --- >> hw/virtio-9p-local.c | 4 ++-- >> oslib-posix.c | 48 ++++++++++++++++++++++++++++++++++++++++++++++++ >> qemu-os-posix.h | 12 ++++++++++++ >> 3 files changed, 62 insertions(+), 2 deletions(-) > > Hi Hidetoshi, > > This looks good to me! > > Acked-by: Jes Sorensen > > Cheers, > Jes