From: Gerd Hoffmann <kraxel@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: qemu-devel@nongnu.org, kvm <kvm@vger.kernel.org>,
Matthew Garrett <mjg59@srcf.ucam.org>,
Adam Jackson <ajax@redhat.com>,
Glauber de Oliveira Costa <gcosta@redhat.com>
Subject: Re: [patch 2/2] support for UHCI suspend / remote wake up
Date: Wed, 01 Dec 2010 16:12:14 +0100 [thread overview]
Message-ID: <4CF665CE.70600@redhat.com> (raw)
In-Reply-To: <20101125170602.676792336@redhat.com>
On 11/25/10 18:04, Marcelo Tosatti wrote:
> This patch enables USB UHCI global suspend/resume feature. The OS will
> stop the HC once all ports are suspended. If there is activity on the
> port(s), an interrupt signalling remote wakeup will be triggered.
>
> To enable autosuspend for the USB tablet on Linux guests:
>
> echo auto> /sys/devices/pci0000:00/0000:00:01.2/usb1/1-1/power/level
Hmm, did you ever got this working sanely?
/me sees bus disconnects in the guest ...
> port->ctrl&= ~(val& 0x000a);
> + port->ctrl&= ~(port->ctrl& 0x0040); /* clear port resume detected */
> }
This chunk looks suspicious ...
I suspect the port suspend/resume emulation isn't complete.
/me goes debugging,
Gerd
next prev parent reply other threads:[~2010-12-01 15:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-25 15:34 PATCH: QEMU support for UHCI suspend / remote wake up Marcelo Tosatti
2010-11-25 16:15 ` Gerd Hoffmann
2010-11-25 17:04 ` [patch 0/2] USB UHCI global suspend / remote wakeup Marcelo Tosatti
2010-11-25 17:04 ` [patch 1/2] add USBBusOps to USBBus Marcelo Tosatti
2010-11-25 17:04 ` [patch 2/2] support for UHCI suspend / remote wake up Marcelo Tosatti
2010-12-01 15:12 ` Gerd Hoffmann [this message]
2010-12-01 16:58 ` Marcelo Tosatti
2010-12-01 17:17 ` Gerd Hoffmann
2010-11-26 0:38 ` [patch 0/2] USB UHCI global suspend / remote wakeup Paul Brook
2010-11-26 2:15 ` [Qemu-devel] " Marcelo Tosatti
2010-11-26 8:49 ` Gerd Hoffmann
2010-11-26 12:09 ` Paul Brook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CF665CE.70600@redhat.com \
--to=kraxel@redhat.com \
--cc=ajax@redhat.com \
--cc=gcosta@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.