From: David Vrabel <david.vrabel@csr.com>
To: Namhyung Kim <namhyung@gmail.com>
Cc: Greg KH <gregkh@suse.de>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] USB: whci-hcd: fix compiler warning
Date: Wed, 01 Dec 2010 17:06:15 +0000 [thread overview]
Message-ID: <4CF68087.2090802@csr.com> (raw)
In-Reply-To: <1291222944.1684.48.camel@leonhard>
Namhyung Kim wrote:
> 2010-12-01 (수), 16:52 +0000, David Vrabel:
>> Namhyung Kim wrote:
>>> I saw it during allyesconfig build but not on allmodconfig.
>>> Maybe we can wrap it up in #ifdef CONFIG_MODULES ?
>> That might be best. Can you do the same with drivers/uwb/whc-rc.c? It
>> will have the same problem.
>>
>> David
>
> No problem. Will send them soon. :)
Actually CONFIG_MODULES is wrong. It needs to test if the driver has
been built as a module or not. I think there's a __MODULE__ or MODULE
#define for this, not sure though.
David
--
David Vrabel, Senior Software Engineer, Drivers
CSR, Churchill House, Cambridge Business Park, Tel: +44 (0)1223 692562
Cowley Road, Cambridge, CB4 0WZ http://www.csr.com/
Member of the CSR plc group of companies. CSR plc registered in England and Wales, registered number 4187346, registered office Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom
next prev parent reply other threads:[~2010-12-01 17:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-01 4:28 [PATCH] USB: whci-hcd: fix compiler warning Namhyung Kim
2010-12-01 16:10 ` Greg KH
2010-12-01 16:49 ` Namhyung Kim
2010-12-01 16:52 ` David Vrabel
2010-12-01 17:02 ` Namhyung Kim
2010-12-01 17:06 ` David Vrabel [this message]
2010-12-01 17:11 ` Namhyung Kim
2010-12-01 17:36 ` Greg KH
2010-12-06 13:05 ` Namhyung Kim
2010-12-06 15:56 ` Greg KH
2010-12-06 16:03 ` [PATCH RESEND] " Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CF68087.2090802@csr.com \
--to=david.vrabel@csr.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=namhyung@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.