Re: [RFC][PATCH V3 1/4] ext4: add EXT4_IOC_CONTROL_PA to create/discard inode PA

[Kazuya Mio <k-mio@sx.jp.nec.com>]

2010/12/01 19:14, Andreas Dilger wrote:
> Is the comment here wrong, or do I misunderstand that there is a 64-bit offset for the file, and only a 32-bit offset for the disk?  It doesn't make sense to create a new API that only has a 32-bit offset for the disk, since ext4 is nearly supporting 64-bit filesystem blocks.

Oops! Thank you for letting me know. I will fix the comments as follows:

struct ext4_prealloc_info {
	__u64 pi_pstart;	/* physical offset for the start of the PA from
				 * the beginning of the disk (in/out) */
	__u32 pi_lstart;	/* logical offset for the start of the PA from
				 * the beginning of the file (in/out) */

Regards,
Kazuya Mio