From: liubo <liubo2009@cn.fujitsu.com>
To: Mike Fedyk <mfedyk@mikefedyk.com>
Cc: "Yan, Zheng" <yanzheng@21cn.com>,
Linux Btrfs <linux-btrfs@vger.kernel.org>,
Josef Bacik <josef@redhat.com>,
Tsutomu Itoh <t-itoh@jp.fujitsu.com>
Subject: Re: [RFC PATCH 2/4 v2] Btrfs: avoid transaction stuff when readonly
Date: Thu, 02 Dec 2010 14:36:47 +0800 [thread overview]
Message-ID: <4CF73E7F.40808@cn.fujitsu.com> (raw)
In-Reply-To: <AANLkTi=WE5FO6YiW18O9_sVUyhHmQQCjdKEzCSFrMaZh@mail.gmail.com>
On 12/02/2010 01:41 PM, Mike Fedyk wrote:
> On Wed, Dec 1, 2010 at 8:28 PM, Yan, Zheng <yanzheng@21cn.com> wrote:
>> On Thu, Dec 2, 2010 at 11:42 AM, liubo <liubo2009@cn.fujitsu.com> wrote:
>>> On 12/01/2010 06:20 PM, liubo wrote:
>>>> When the filesystem is readonly, avoid transaction stuff by checking MS_RDONLY at
>>>> start transaction time.
>>>>
>>> This patch may lead btrfs panic.
>>>
>>> Since btrfs allows transaction under readonly fs state, which is a bit weird, btrfs
>>> does not even check the returned transaction from start_transaction, although it may
>>> return -ENOMEM.
>> btrfs may do log replay even mount as readonly.
>>
>
> What part is logged besides tree roots and/or superblocks?
log tree is used for log replay after crash and fast fsync and O_SYNC, it logs
inodes.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2010-12-02 6:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-01 10:20 [RFC PATCH 2/4 v2] Btrfs: avoid transaction stuff when readonly liubo
2010-12-02 3:42 ` liubo
2010-12-02 4:28 ` Yan, Zheng
2010-12-02 5:38 ` liubo
2010-12-02 5:41 ` Mike Fedyk
2010-12-02 6:36 ` liubo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CF73E7F.40808@cn.fujitsu.com \
--to=liubo2009@cn.fujitsu.com \
--cc=josef@redhat.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=mfedyk@mikefedyk.com \
--cc=t-itoh@jp.fujitsu.com \
--cc=yanzheng@21cn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.