Re: [PATCH] kvm-vmx: add module parameter to avoid trapping HLT instructions

[Avi Kivity <avi@redhat.com>]

On 12/01/2010 08:03 PM, Anthony Liguori wrote:
> In certain use-cases, we want to allocate guests fixed time slices where idle
> guest cycles leave the machine idling.  There are many approaches to achieve
> this but the most direct is to simply avoid trapping the HLT instruction which
> lets the guest directly execute the instruction putting the processor to sleep.
>
> Introduce this as a module-level option for kvm-vmx.ko since if you do this
> for one guest, you probably want to do it for all.  A similar option is possible
> for AMD but I don't have easy access to AMD test hardware.

Looks reasonable.

> +static int __read_mostly enable_yield_on_guest_hlt = 1;
> +module_param(enable_yield_on_guest_hlt, bool, S_IRUGO);
> +

Please rename to yield_on_hlt.  Also, should not be __read_mostly 
(__read_mostly is for variables that are also __read_often).


-- 
error compiling committee.c: too many arguments to function