All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nick Thompson <nick.thompson@ge.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] davinci: Rewrite timer.c to use tbl/tbu emulation variables in gd
Date: Thu, 02 Dec 2010 14:37:49 +0000	[thread overview]
Message-ID: <4CF7AF3D.8010902@ge.com> (raw)
In-Reply-To: <AANLkTiniEHxMAyqf3_6fWp-HGXBSO=8DYaE_=6J2DG2o@mail.gmail.com>

On 02/12/10 14:18, Ben Gardiner wrote:
> Hi Nick,
> 
> On Thu, Dec 2, 2010 at 8:57 AM, Nick Thompson <nick.thompson@ge.com> wrote:
>> This change allows the davinci timer functions to be used before
>> relocation since it avoids using static variables prior to BSS being
>> made available.

>> Signed-off-by: Nick Thompson <nick.thompson@ge.com>
>> ---
>> This patch relies on http://patchwork.ozlabs.org/patch/73758/ which has not been
>> accepted yet. I have made a comment on it, suggesting that it should be changed:
>> http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/90040/focus=90162

> 
> Applies cleanly to v2010.12-rc2 on top of
> http://patchwork.ozlabs.org/patch/73758/
> 
> Tested on da850evm w/o any config changes. This fixes the freeze on
> boot: 10/10 times.
> 
> You're awesome, Nick!
> 
> Tested-by: Ben Gardiner <bengardiner@nanometrics.ca>

I thought it sounded like the problem you where having. Glad it helps.

Thanks for the Tested-by.

>> +       endtime = ((unsigned long long )usec * gd->timer_rate_hz) / 1000000UL;
> 
> just one minor checkpatch.pl warning; should be (unsigned long long)
> -- no space before ')'

Good spot. I've fixed that locally and will submit a v2 if the depending
patch finds favour - Alternative approaches have been suggested, this one
is *my* short-term favourite.

Thanks,
Nick.

  reply	other threads:[~2010-12-02 14:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-02 13:57 [U-Boot] [PATCH] davinci: Rewrite timer.c to use tbl/tbu emulation variables in gd Nick Thompson
2010-12-02 14:18 ` Ben Gardiner
2010-12-02 14:37   ` Nick Thompson [this message]
2010-12-03  8:59 ` Sudhakar Rajashekhara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CF7AF3D.8010902@ge.com \
    --to=nick.thompson@ge.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.