All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Marek <mmarek@suse.cz>
To: Patrick LeBoutillier <patrick.leboutillier@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Bug in scripts/package/mkspec?
Date: Thu, 02 Dec 2010 16:25:33 +0100	[thread overview]
Message-ID: <4CF7BA6D.60002@suse.cz> (raw)
In-Reply-To: <AANLkTin01j5oTUdh6fAgs--Gi46BZOWZCdypUPd8uhm4@mail.gmail.com>

On 18.11.2010 19:13, Patrick LeBoutillier wrote:
> Hi all,
> 
> I've been building RPMs for the Linux kernel for a while now and only
> recently noticed that the RPM Release field is always set to 1.
> After a bit of searching I found the offending line in
> scripts/package/mkspec. Here is a patch that worked for me, but
> perhaps this
> could be fixed in better way by someone knowledgeable of the kernel
> build process...:
> 
> 
> --- ./mkspec.next       2010-11-18 13:08:56.000000000 -0500
> +++ mkspec      2010-11-18 13:10:13.000000000 -0500
> @@ -29,7 +29,7 @@
>  echo "Version: $__KERNELRELEASE"
>  # we need to determine the NEXT version number so that uname and
>  # rpm -q will agree
> -echo "Release: `. $srctree/scripts/mkversion`"
> +echo "Release: `cd $srctree && ./scripts/mkversion`"

This doesn't look correct to me, the script reads the .version file
which is in the build directory, not in the source dir. Can you post a
step-by-step reproducer for your bug?

Thanks,
Michal

  reply	other threads:[~2010-12-02 15:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-18 18:13 [PATCH] Bug in scripts/package/mkspec? Patrick LeBoutillier
2010-12-02 15:25 ` Michal Marek [this message]
2010-12-02 21:15   ` Patrick LeBoutillier
2011-01-06 12:54     ` Michal Marek
2011-01-06 14:28       ` Patrick LeBoutillier
2011-01-06 15:53         ` Michal Marek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CF7BA6D.60002@suse.cz \
    --to=mmarek@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patrick.leboutillier@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.