All of lore.kernel.org
 help / color / mirror / Atom feed
From: Seth Goldberg <seth.goldberg@oracle.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: Need --divide flag for assembly of startup.S on some platforms
Date: Thu, 02 Dec 2010 13:39:41 -0800	[thread overview]
Message-ID: <4CF8121D.6000507@oracle.com> (raw)
In-Reply-To: <20101202212920.GX21862@riva.ucam.org>

On 12/ 2/10 01:29 PM, Colin Watson wrote:
> On Thu, Dec 02, 2010 at 01:15:10PM -0800, Seth Goldberg wrote:
>>    When assembling grub-core/kern/i386/pc/startup.S, gas on some platforms
>> chokes on this line:
>>
>>         movl    $((LOCAL(bypass_table_end) - LOCAL(bypass_table)) / 2), %ecx
>>
>>   Because on non i386-linux targets, '/' is used as a comment delimiter
>> for compatibility purposes.  This can be overridden with the --divide
>> switch.
>>
>>    Since the default for gas on these platforms is to use he division
>> operator as a comment delimiter, the "-Wa,--divide" flags need to be
>> passed on the gcc command line when assembling such files.
> Can we just use>>  1 instead?

   Sure, that works for me :).

  --S


  reply	other threads:[~2010-12-02 21:41 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-01 15:51 BtrFS available in experimental Vladimir 'φ-coder/phcoder' Serbinenko
2010-12-02 14:41 ` Vladimir 'φ-coder/phcoder' Serbinenko
2010-12-02 21:15   ` Need --divide flag for assembly of startup.S on some platforms Seth Goldberg
2010-12-02 21:29     ` Colin Watson
2010-12-02 21:39       ` Seth Goldberg [this message]
2010-12-03  0:53         ` Error building grub-emu (gnulib/progname.c) Seth Goldberg
2010-12-03  1:07           ` Seth Goldberg
2010-12-03  1:20             ` Seth Goldberg
2010-12-03  1:29             ` Another error building grub-emu (gnulib/error.c) Seth Goldberg
2010-12-03  1:39               ` Seth Goldberg
2010-12-02 21:42       ` Need --divide flag for assembly of startup.S on some platforms Vladimir 'φ-coder/phcoder' Serbinenko
2010-12-04 15:47         ` Colin Watson
2010-12-04 16:20           ` Colin Watson
2010-12-03 21:20     ` Need LARGEFILE_SOURCE && _FILE_OFFSET_BITS=64 Seth Goldberg
2010-12-04 15:25       ` Colin Watson
2010-12-06  7:18         ` Seth Goldberg
2010-12-03 21:02   ` BtrFS available in experimental Vladimir 'φ-coder/phcoder' Serbinenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CF8121D.6000507@oracle.com \
    --to=seth.goldberg@oracle.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.