From: Mohammed Shafi <mshajakhan@atheros.com>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] ath9k: Properly use unlikely check macro
Date: Fri, 3 Dec 2010 10:14:07 +0530 [thread overview]
Message-ID: <4CF87597.5080900@atheros.com> (raw)
In-Reply-To: <20101202202127.GF2358@tuxdriver.com>
On Friday 03 December 2010 01:51 AM, John W. Linville wrote:
> On Mon, Nov 29, 2010 at 08:57:57PM +0530, Mohammed Shafi Shajakhan wrote:
>
>> From: Mohammed Shafi Shajakhan<mshajakhan@atheros.com>
>>
>> AUTOSLEEP feature is enabled only AR9003 and later chips.So unlikely
>> macro should be used only to check whether auto-sleep feature is enabled
>>
>> Signed-off-by: Mohammed Shafi Shajakhan<mshajakhan@atheros.com>
>> ---
>> drivers/net/wireless/ath/ath9k/recv.c | 6 +++---
>> 1 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/net/wireless/ath/ath9k/recv.c b/drivers/net/wireless/ath/ath9k/recv.c
>> index 262c815..751ee1b 100644
>> --- a/drivers/net/wireless/ath/ath9k/recv.c
>> +++ b/drivers/net/wireless/ath/ath9k/recv.c
>> @@ -1743,10 +1743,10 @@ int ath_rx_tasklet(struct ath_softc *sc, int flush, bool hp)
>> }
>>
>> spin_lock_irqsave(&sc->sc_pm_lock, flags);
>> - if (unlikely(ath9k_check_auto_sleep(sc) ||
>> - (sc->ps_flags& (PS_WAIT_FOR_BEACON |
>> + if ((sc->ps_flags& (PS_WAIT_FOR_BEACON |
>> PS_WAIT_FOR_CAB |
>> - PS_WAIT_FOR_PSPOLL_DATA))))
>> + PS_WAIT_FOR_PSPOLL_DATA)) ||
>> + unlikely(ath9k_hw_check_auto_sleep(sc)))
>> ath_rx_ps(sc, skb);
>> spin_unlock_irqrestore(&sc->sc_pm_lock, flags);
>>
> What tree is this against?
>
2.6.37-rc4 ..Any problems in applying.Do I have to resend it based on
the latest pull ?
thanks,
shafi
next prev parent reply other threads:[~2010-12-03 4:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-29 15:27 [PATCH] ath9k: Properly use unlikely check macro Mohammed Shafi Shajakhan
2010-12-02 20:21 ` John W. Linville
2010-12-03 4:44 ` Mohammed Shafi [this message]
2010-12-03 14:59 ` John W. Linville
2010-12-03 15:08 ` Mohammed Shafi
2010-12-03 15:24 ` Mohammed Shafi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CF87597.5080900@atheros.com \
--to=mshajakhan@atheros.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.