From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sylwester Nawrocki Subject: Re: [PATCH 2/4] mach-s5pv310: Add resource definitions for mipi-csis Date: Fri, 03 Dec 2010 11:24:24 +0100 Message-ID: <4CF8C558.8020606@samsung.com> References: <1291307862-8125-1-git-send-email-s.nawrocki@samsung.com> <1291307862-8125-3-git-send-email-s.nawrocki@samsung.com> <012401cb92a3$a46443b0$ed2ccb10$%kim@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7BIT Return-path: Received: from mailout4.w1.samsung.com ([210.118.77.14]:34801 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752441Ab0LCKY1 (ORCPT ); Fri, 3 Dec 2010 05:24:27 -0500 Received: from eu_spt1 ([210.118.77.14]) by mailout4.w1.samsung.com (Sun Java(tm) System Messaging Server 6.3-8.04 (built Jul 29 2009; 32bit)) with ESMTP id <0LCU000QXKWPT110@mailout4.w1.samsung.com> for linux-samsung-soc@vger.kernel.org; Fri, 03 Dec 2010 10:24:25 +0000 (GMT) Received: from linux.samsung.com ([106.116.38.10]) by spt1.w1.samsung.com (iPlanet Messaging Server 5.2 Patch 2 (built Jul 14 2004)) with ESMTPA id <0LCU00JLRKWON6@spt1.w1.samsung.com> for linux-samsung-soc@vger.kernel.org; Fri, 03 Dec 2010 10:24:25 +0000 (GMT) In-reply-to: Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Jassi Brar Cc: Kukjin Kim , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, kyungmin.park@samsung.com, ben-linux@fluff.org, m.szyprowski@samsung.com On 12/03/2010 05:59 AM, Jassi Brar wrote: > On Fri, Dec 3, 2010 at 1:36 PM, Kukjin Kim wrote: >> Sylwester Nawrocki wrote: >>> >>> Add IRQ and register base address definitions for mipi-csis devices. >>> >>> Signed-off-by: Sylwester Nawrocki >>> Signed-off-by: Kyungmin Park >>> --- >>> arch/arm/mach-s5pv310/include/mach/irqs.h | 3 +++ >>> arch/arm/mach-s5pv310/include/mach/map.h | 5 +++++ >>> 2 files changed, 8 insertions(+), 0 deletions(-) >>> >>> diff --git a/arch/arm/mach-s5pv310/include/mach/irqs.h b/arch/arm/mach- >>> s5pv310/include/mach/irqs.h >>> index 99e7dad..db63773 100644 >>> --- a/arch/arm/mach-s5pv310/include/mach/irqs.h >>> +++ b/arch/arm/mach-s5pv310/include/mach/irqs.h >>> @@ -83,6 +83,9 @@ >>> #define IRQ_HSMMC2 COMBINER_IRQ(29, 2) >>> #define IRQ_HSMMC3 COMBINER_IRQ(29, 3) >>> >>> +#define IRQ_MIPICSI0 COMBINER_IRQ(30, 0) >>> +#define IRQ_MIPICSI1 COMBINER_IRQ(30, 1) >>> + >>> #define IRQ_ONENAND_AUDI COMBINER_IRQ(34, 0) >>> >>> #define IRQ_EINT4 COMBINER_IRQ(37, 0) >>> diff --git a/arch/arm/mach-s5pv310/include/mach/map.h b/arch/arm/mach- >>> s5pv310/include/mach/map.h >>> index 7acf4e7..9905bfe 100644 >>> --- a/arch/arm/mach-s5pv310/include/mach/map.h >>> +++ b/arch/arm/mach-s5pv310/include/mach/map.h >>> @@ -56,6 +56,9 @@ >>> #define S5PV310_PA_GPIO2 (0x11000000) >>> #define S5PV310_PA_GPIO3 (0x03860000) >>> >>> +#define S5PV310_PA_CSIS0 (0x11880000) >>> +#define S5PV310_PA_CSIS1 (0x11890000) > > Let us please not contain constants in brackets. > I don't like those brackets too, so I am going to remove them in the next patch version. Unless anyone raises an objection. It is hard to make everyone happy though. Sometimes good coding practice prevails over consistency. However this time it looks like me judgement was wrong ;-) Thanks, -- Sylwester Nawrocki Linux Platform Group Samsung Poland R&D Center From mboxrd@z Thu Jan 1 00:00:00 1970 From: s.nawrocki@samsung.com (Sylwester Nawrocki) Date: Fri, 03 Dec 2010 11:24:24 +0100 Subject: [PATCH 2/4] mach-s5pv310: Add resource definitions for mipi-csis In-Reply-To: References: <1291307862-8125-1-git-send-email-s.nawrocki@samsung.com> <1291307862-8125-3-git-send-email-s.nawrocki@samsung.com> <012401cb92a3$a46443b0$ed2ccb10$%kim@samsung.com> Message-ID: <4CF8C558.8020606@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 12/03/2010 05:59 AM, Jassi Brar wrote: > On Fri, Dec 3, 2010 at 1:36 PM, Kukjin Kim wrote: >> Sylwester Nawrocki wrote: >>> >>> Add IRQ and register base address definitions for mipi-csis devices. >>> >>> Signed-off-by: Sylwester Nawrocki >>> Signed-off-by: Kyungmin Park >>> --- >>> arch/arm/mach-s5pv310/include/mach/irqs.h | 3 +++ >>> arch/arm/mach-s5pv310/include/mach/map.h | 5 +++++ >>> 2 files changed, 8 insertions(+), 0 deletions(-) >>> >>> diff --git a/arch/arm/mach-s5pv310/include/mach/irqs.h b/arch/arm/mach- >>> s5pv310/include/mach/irqs.h >>> index 99e7dad..db63773 100644 >>> --- a/arch/arm/mach-s5pv310/include/mach/irqs.h >>> +++ b/arch/arm/mach-s5pv310/include/mach/irqs.h >>> @@ -83,6 +83,9 @@ >>> #define IRQ_HSMMC2 COMBINER_IRQ(29, 2) >>> #define IRQ_HSMMC3 COMBINER_IRQ(29, 3) >>> >>> +#define IRQ_MIPICSI0 COMBINER_IRQ(30, 0) >>> +#define IRQ_MIPICSI1 COMBINER_IRQ(30, 1) >>> + >>> #define IRQ_ONENAND_AUDI COMBINER_IRQ(34, 0) >>> >>> #define IRQ_EINT4 COMBINER_IRQ(37, 0) >>> diff --git a/arch/arm/mach-s5pv310/include/mach/map.h b/arch/arm/mach- >>> s5pv310/include/mach/map.h >>> index 7acf4e7..9905bfe 100644 >>> --- a/arch/arm/mach-s5pv310/include/mach/map.h >>> +++ b/arch/arm/mach-s5pv310/include/mach/map.h >>> @@ -56,6 +56,9 @@ >>> #define S5PV310_PA_GPIO2 (0x11000000) >>> #define S5PV310_PA_GPIO3 (0x03860000) >>> >>> +#define S5PV310_PA_CSIS0 (0x11880000) >>> +#define S5PV310_PA_CSIS1 (0x11890000) > > Let us please not contain constants in brackets. > I don't like those brackets too, so I am going to remove them in the next patch version. Unless anyone raises an objection. It is hard to make everyone happy though. Sometimes good coding practice prevails over consistency. However this time it looks like me judgement was wrong ;-) Thanks, -- Sylwester Nawrocki Linux Platform Group Samsung Poland R&D Center