From: "Torsten Bögershausen" <tboegi@web.de>
To: normalperson@yhbt.net, git@vger.kernel.org, gitster@pobox.com
Cc: tboegi@web.de
Subject: [PATCH] t9143: do not fail when unhandled.log.gz is not created
Date: Sat, 04 Dec 2010 12:37:04 +0100 [thread overview]
Message-ID: <4CFA27E0.8070308@web.de> (raw)
Commit df73af5f66 is does not let the test case fail,
when Compress::Zlib is missing.
But:
On a MacOS X 10.6 system with missing Compress::Zlib
using svn version 1.6.5 (r38866) the gz file is created.
Solution:
Check for the existance of the unhandled.log.gz file.
Signed-off-by: Torsten Bögershausen <tboegi@web.de>
---
t/t9143-git-svn-gc.sh | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/t/t9143-git-svn-gc.sh b/t/t9143-git-svn-gc.sh
index 337ea59..8a95d78 100755
--- a/t/t9143-git-svn-gc.sh
+++ b/t/t9143-git-svn-gc.sh
@@ -37,7 +37,7 @@ test_expect_success 'git svn gc runs' 'git svn gc'
test_expect_success 'git svn index removed' '! test -f
.git/svn/refs/remotes/git-svn/index'
-if perl -MCompress::Zlib -e 0 2>/dev/null
+if test -r .git/svn/refs/remotes/git-svn/unhandled.log.gz
then
test_expect_success 'git svn gc produces a valid gzip file' '
gunzip .git/svn/refs/remotes/git-svn/unhandled.log.gz
--
1.6.6
next reply other threads:[~2010-12-04 11:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-04 11:37 Torsten Bögershausen [this message]
2010-12-06 19:23 ` [PATCH] t9143: do not fail when unhandled.log.gz is not created Eric Wong
2010-12-08 16:25 ` Torsten Bögershausen
2010-12-08 21:41 ` Eric Wong
-- strict thread matches above, loose matches on Subject: below --
2010-12-09 19:53 Torsten Bögershausen
2010-12-09 21:31 ` Eric Wong
2010-12-10 0:11 ` Junio C Hamano
2010-12-04 11:37 Torsten Bögershausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CFA27E0.8070308@web.de \
--to=tboegi@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=normalperson@yhbt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.