From: Sergei Shtylyov <sshtylyov@mvista.com>
To: anoop pa <anoop.pa@gmail.com>
Cc: Ralf Baechle <ralf@linux-mips.org>,
linux-mips@linux-mips.org, mcdonald.shane@gmail.com
Subject: Re: [RFC 1/3] VSMP support for msp71xx family of platforms.
Date: Sun, 05 Dec 2010 17:00:53 +0300 [thread overview]
Message-ID: <4CFB9B15.9050308@mvista.com> (raw)
In-Reply-To: <AANLkTinkF8_2hO7Ko=S6w2NPPX8oGTcdbRyd=7N0mUbM@mail.gmail.com>
Hello.
On 02-12-2010 20:27, anoop pa wrote:
>>> -obj-$(CONFIG_IRQ_MSP_CIC) += msp_irq_cic.o
>>> +obj-$(CONFIG_IRQ_MSP_CIC) += msp_irq_cic.o msp_irq_per.o
>> What does this change have to do with the rest of the patch?
> This change is required for next patch in this. series.Is this
> potentially wrong .
It's not wrong -- it's just that one patch needs to address one issue. Or
at least you should describe all your changed in the changelog.
> Do I want to move this to next patch?
I don't know what you want. :-)
>>> + set_vi_handler (MIPS_CPU_IPI_CALL_IRQ, ipi_call_dispatch);
>> Spaces between the function name and ( are not allowed -- run your patch
>> thru scripts/checkpatch.pl.
> Not sure what went wrong. I had checked it before sending .
> linux.git$ ./scripts/checkpatch.pl
> 0001-VSMP-support-for-msp71xx-family-of-platforms.patch
> total: 0 errors, 0 warnings, 84 lines checked
> 0001-VSMP-support-for-msp71xx-family-of-platforms.patch has no obvious
> style problems and is ready for submission.
I'm not sure -- perhaps checkpatch.pl has stopped complaing about those
spaces... but it ceratainly did in the past.
> Regards,
> Anoop
WBR, Sergei
prev parent reply other threads:[~2010-12-05 14:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-01 16:18 [RFC 1/3] VSMP support for msp71xx family of platforms Anoop P A
2010-12-01 16:18 ` Anoop P A
2010-12-02 11:47 ` Sergei Shtylyov
2010-12-02 17:27 ` anoop pa
2010-12-05 14:00 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CFB9B15.9050308@mvista.com \
--to=sshtylyov@mvista.com \
--cc=anoop.pa@gmail.com \
--cc=linux-mips@linux-mips.org \
--cc=mcdonald.shane@gmail.com \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.