Re: [PATCH 2/2] i2c-intel-mid: improve timeout handling

[Ben Dooks <ben-i2c-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>]

On 24/11/10 14:49, Alan Cox wrote:
> From: Bin Yang <bin.yang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> 
> The old solution for i2c xfer timeout was to set timeout value to one second
> for all i2c xfers.  That's not reasonable for all of the various speed modes
> and data lengths.
> 
> This patch sets the xfer_read timeout value based on both bus speed and data
> length.
> 
> Signed-off-by: Bin Yang <bin.yang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> [Ported to the upstream branch and extracted as a helper function]
> Signed-off-by: Alan Cox <alan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
> ---
> 
>  drivers/i2c/busses/i2c-intel-mid.c |   31 +++++++++++++++++++++++++++----
>  1 files changed, 27 insertions(+), 4 deletions(-)
> 
> 
> diff --git a/drivers/i2c/busses/i2c-intel-mid.c b/drivers/i2c/busses/i2c-intel-mid.c
> index bdf17da..b39abd8 100644
> --- a/drivers/i2c/busses/i2c-intel-mid.c
> +++ b/drivers/i2c/busses/i2c-intel-mid.c
> @@ -303,6 +303,29 @@ static int ctl_num = 6;
>  module_param_array(speed_mode, int, &ctl_num, S_IRUGO);
>  MODULE_PARM_DESC(speed_mode, "Set the speed of the i2c interface (0-2)");

ok, will queue for next merge window