From: Avi Kivity <avi@redhat.com>
To: Takuya Yoshikawa <yoshikawa.takuya@oss.ntt.co.jp>
Cc: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>,
Takuya Yoshikawa <takuya.yoshikawa@gmail.com>,
mtosatti@redhat.com, kvm@vger.kernel.org
Subject: Re: [PATCH 2/2 rebased] KVM: MMU: Introduce a helper to access lpage_info
Date: Mon, 06 Dec 2010 15:07:50 +0200 [thread overview]
Message-ID: <4CFCE026.9060708@redhat.com> (raw)
In-Reply-To: <4CFCA584.2030609@oss.ntt.co.jp>
On 12/06/2010 10:57 AM, Takuya Yoshikawa wrote:
> (2010/12/06 16:55), Takuya Yoshikawa wrote:
>> (2010/12/06 15:37), Xiao Guangrong wrote:
>>> On 12/06/2010 12:13 AM, Takuya Yoshikawa wrote:
>>>> From: Takuya Yoshikawa<yoshikawa.takuya@oss.ntt.co.jp>
>>>>
>>>> Index calculation to access lpage_info appears three times.
>>>> A helper is worthwhile.
>>>>
>>>
>>> Why not get lpage_info instead of index in the helper?
>>
>> Seems a better way! I didn't think about it.
>>
>> I'll check and resend [2/2] if it's OK.
>>
>
> Sadly, the structure of lpage_info has no name.
>
Well, you can give it a name. Meanwhile I've applied patch 1, thanks.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2010-12-06 13:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-05 16:11 [PATCH 1/2 rebased] KVM: MMU: Avoid dropping accessed bit while removing write access Takuya Yoshikawa
2010-12-05 16:13 ` [PATCH 2/2 rebased] KVM: MMU: Introduce a helper to access lpage_info Takuya Yoshikawa
2010-12-06 6:37 ` Xiao Guangrong
2010-12-06 7:55 ` Takuya Yoshikawa
2010-12-06 8:57 ` Takuya Yoshikawa
2010-12-06 13:07 ` Avi Kivity [this message]
2010-12-07 3:59 ` [PATCH 2/2 v2] KVM: MMU: Make the way of accessing lpage_info more generic Takuya Yoshikawa
2010-12-07 13:55 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CFCE026.9060708@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=takuya.yoshikawa@gmail.com \
--cc=xiaoguangrong@cn.fujitsu.com \
--cc=yoshikawa.takuya@oss.ntt.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.