From: David Daney <ddaney@caviumnetworks.com>
To: Anoop P A <anoop.pa@gmail.com>
Cc: Ralf Baechle <ralf@linux-mips.org>,
linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Introduce mips_late_time_init
Date: Mon, 06 Dec 2010 09:42:45 -0800 [thread overview]
Message-ID: <4CFD2095.9040404@caviumnetworks.com> (raw)
In-Reply-To: <1291623812.31822.6.camel@paanoop1-desktop>
On 12/06/2010 12:23 AM, Anoop P A wrote:
> This patch moves plat_time_init and clocksoure init funtion calls to
> late_time_init.
>
Why would you want to do this?
The current code works perfectly, so I see no reason to change it.
David Daney
> Signed-off-by: Anoop P A<anoop.pa@gmail.com>
> ---
> diff --git a/arch/mips/kernel/time.c b/arch/mips/kernel/time.c
> index fb74974..dbd1ac5 100644
> --- a/arch/mips/kernel/time.c
> +++ b/arch/mips/kernel/time.c
> @@ -117,10 +117,16 @@ static __init int cpu_has_mfc0_count_bug(void)
> return 0;
> }
>
> -void __init time_init(void)
> +void __init mips_late_time_init(void)
> {
> plat_time_init();
>
> if (!mips_clockevent_init() || !cpu_has_mfc0_count_bug())
> init_mips_clocksource();
> }
> +
> +
> +void __init time_init(void)
> +{
> + late_time_init = mips_late_time_init;
> +}
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
next prev parent reply other threads:[~2010-12-06 17:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-06 8:23 [PATCH] Introduce mips_late_time_init Anoop P A
2010-12-06 17:42 ` David Daney [this message]
2010-12-08 20:37 ` Ralf Baechle
2010-12-08 21:21 ` Thomas Gleixner
2010-12-08 22:45 ` Benjamin Herrenschmidt
2010-12-10 17:21 ` Paul Mundt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CFD2095.9040404@caviumnetworks.com \
--to=ddaney@caviumnetworks.com \
--cc=anoop.pa@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.