From: Clemens Ladisch <clemens@ladisch.de>
To: sudarshan.bisht@nokia.com
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Subject: Re: [PATCH 0/2] Fixed issues/defects reported by Coverity tool.
Date: Tue, 07 Dec 2010 14:47:41 +0100 [thread overview]
Message-ID: <4CFE3AFD.3070008@ladisch.de> (raw)
In-Reply-To: <1291719547.2355.155.camel@Sudarshan.research.nokia.com>
Sudarshan Bisht wrote:
> * First patch here is just a cosmetic one as it removes
> tabs and trailing whitespaces from the code.
The ALSA code uses kernel style, not PulseAudio; please don't remove
tabs.
> * Second patch has got fixes for some minor issues/defects
> reported by Coverity tool and these fixes can prevent memory
> leaks and crashes in some cases. It also has some whitespaces
> and tabs removal differences, please ignore them.
The whitespace stuff makes it hard to review the patches.
Please run diff with the -w parameter to ignore that.
Regards,
Clemens
prev parent reply other threads:[~2010-12-07 13:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-03 12:06 [PATCH 0/2] Fixed issues/defects reported by Coverity tool sudarshan.bisht
2010-12-06 12:51 ` Clemens Ladisch
2010-12-07 10:40 ` Sudarshan Bisht
2010-12-07 10:59 ` Sudarshan Bisht
2010-12-07 13:47 ` Clemens Ladisch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CFE3AFD.3070008@ladisch.de \
--to=clemens@ladisch.de \
--cc=alsa-devel@alsa-project.org \
--cc=sudarshan.bisht@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.