[Qemu-devel] Re: [PATCH 1/1] qemu-img: Deprecate obsolete -6 and -e options

[Jes Sorensen <Jes.Sorensen@redhat.com>]

On 12/07/10 17:02, Kevin Wolf wrote:
>> @@ -323,11 +310,13 @@ static int img_create(int argc, char **argv)
>>              fmt = optarg;
>>              break;
>>          case 'e':
>> -            flags |= BLOCK_FLAG_ENCRYPT;
>> -            break;
>> +            printf("qemu-img: option -e is deprecated, please use \'-o "
>> +                   "encryption\' instead!\n");
>> +            return -1;
> 
> The return value of this function is used as exit code of qemu-img, so 1
> is probably better than -1.
> 
> Also, is there a reason why you use printf and not error (which writes
> the message to stderr)?

I looked for fprintf(stderr.... and found nothing so I used printf()
instead. I'm happy to change it to use error() and the return value too.

Thanks for the feedback.

Cheers,
Jes