All of lore.kernel.org
 help / color / mirror / Atom feed
From: "René Scharfe" <rene.scharfe@lsrfire.ath.cx>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Thiago Farina <tfransosi@gmail.com>,
	Git Mailing List <git@vger.kernel.org>
Subject: Re: cmd_cherry in builtin/log.c?
Date: Tue, 07 Dec 2010 19:57:38 +0100	[thread overview]
Message-ID: <4CFE83A2.8070004@lsrfire.ath.cx> (raw)
In-Reply-To: <20101207173923.GA21483@burratino>

Am 07.12.2010 18:39, schrieb Jonathan Nieder:
> while the core of the builtin version is
> 
> 	get_patch_ids(&revs, &patch_id_opts, prefix);
> 
> The latter function is static, introduced by v1.4.1~12^2~5
> (format-patch: introduce "--ignore-if-in-upstream", 2006-06-25).
> 
> So the answer is that "git cherry" is considered a variant on
> "git log" (like format-patch, show, and whatchanged) and that it uses
> "git log" internals.

That's right.  get_patch_ids() could be moved into patch-ids.c now and
then cmd_cherry() could get its own file in builtin/, though.

René

  reply	other threads:[~2010-12-07 18:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-07 16:02 cmd_cherry in builtin/log.c? Thiago Farina
2010-12-07 17:39 ` Jonathan Nieder
2010-12-07 18:57   ` René Scharfe [this message]
2010-12-07 20:30     ` Junio C Hamano
2010-12-09 21:14       ` René Scharfe
2010-12-08 11:57   ` Thiago Farina
2010-12-08 18:09     ` Jonathan Nieder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CFE83A2.8070004@lsrfire.ath.cx \
    --to=rene.scharfe@lsrfire.ath.cx \
    --cc=git@vger.kernel.org \
    --cc=jrnieder@gmail.com \
    --cc=tfransosi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.