From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anssi Hannula Subject: Re: [PATCH #upstream] ahci: add HFLAG_YES_FBS and apply it to 88SE9128 Date: Tue, 07 Dec 2010 21:45:38 +0200 Message-ID: <4CFE8EE2.1060908@iki.fi> References: <4C4AFE7C.5070506@kernel.org> <4CF45BC0.2030701@iki.fi> <4CF4FCBE.2060406@kernel.org> <4CF55A4B.1020402@iki.fi> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from sypressi.dnainternet.net ([83.102.40.135]:38114 "EHLO sypressi.dnainternet.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752518Ab0LGTpo (ORCPT ); Tue, 7 Dec 2010 14:45:44 -0500 In-Reply-To: <4CF55A4B.1020402@iki.fi> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Tejun Heo Cc: Jeff Garzik , "linux-ide@vger.kernel.org" , Mark Lord On 30.11.2010 22:10, Anssi Hannula wrote: > On 30.11.2010 15:31, Tejun Heo wrote: >> Hello, Hi! >> On 11/30/2010 03:04 AM, Anssi Hannula wrote: >>> On 24.07.2010 17:53, Tejun Heo wrote: >>>> 88SE9128 can do FBS and sets it in HOST_CAP but forgets to set FBSCP >>>> in PORT_CMD. Implement AHCI_HFLAG_YES_FBS and apply it to 88SE9128. >>>> >>>> Signed-off-by: Tejun Heo >>> [...] >>>> diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c >>>> index f252253..41fa0a3 100644 >>> [...] >>>> @@ -362,6 +371,8 @@ static const struct pci_device_id ahci_pci_tbl[] = { >>>> /* Marvell */ >>>> { PCI_VDEVICE(MARVELL, 0x6145), board_ahci_mv }, /* 6145 */ >>>> { PCI_VDEVICE(MARVELL, 0x6121), board_ahci_mv }, /* 6121 */ >>>> + { PCI_DEVICE(0x1b4b, 0x9123), >>>> + .driver_data = board_ahci_yes_fbs }, /* 88se9128 */ >>> >>> The device contains an IDE interface as well, and the above >>> pci_device_id matches them both: >>> 08:00.0 SATA controller [0106]: Device [1b4b:9123] (rev 10) >>> 08:00.1 IDE interface [0101]: Device [1b4b:9123] (rev 10) >> >> *GASP* Come on Marvell.... :-( >> >>> This results in some (apparently harmless) mess [1]. >>> >>> Attached is a patch to make the id entry class-specific. The patch is >>> untested (the issue happens in a production machine). >> >> Thanks a lot for the patch. It looks correct but it would be great if >> it can be veified. > > I think I can do that later, but probably not this week or so. I've now verified that the patch works on a system with 1b4b:9123 controller. >> Also, there's a pending patch to add another PCI >> ID for similar marvell controller. I wonder whether similar >> workaround should be applied. Hmmm... ISTR the other one reporting >> IDE class even though it works in IDE mode. > > IDE class in IDE mode? Isn't that kind of expected? :) > > Also, just to avoid any misunderstanding: I see both the SATA and IDE > interfaces at the same time. > >> Can someone with marvell >> documentation access check what's going on? >> >> Thanks. >> > -- Anssi Hannula