From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=45812 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PQFF3-0005Do-63
	for qemu-devel@nongnu.org; Wed, 08 Dec 2010 03:19:14 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1PQFF0-0003ex-GG
	for qemu-devel@nongnu.org; Wed, 08 Dec 2010 03:19:13 -0500
Received: from mx1.redhat.com ([209.132.183.28]:57052)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1PQFF0-0003eX-9M
	for qemu-devel@nongnu.org; Wed, 08 Dec 2010 03:19:10 -0500
Message-ID: <4CFF3F48.800@redhat.com>
Date: Wed, 08 Dec 2010 09:18:16 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] State of EHCI emulation for QEMU
References: <4CDEE6C5.3010808@web.de> <4CF988EC.6010004@redhat.com>
	<4CFA0462.8080407@web.de>
In-Reply-To: <4CFA0462.8080407@web.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Jes Sorensen <Jes.Sorensen@redhat.com>, qemu-devel <qemu-devel@nongnu.org>, "David S. Ahern" <daahern@cisco.com>

   Hi,

> - command line must look like this:
>          ...
>          -drive if=none,id=usbstick,file=/path/to/image   \
>          -device usb-storage,bus=ehci.0,drive=usbstick
>    ie. register driver device referencing it, and there was a typo id->if

I'll fix.

> - long-term, "-usb" should become a shorthand for "-device
>    usb-uhci,id=uhci -device usb-ehci,id=ehci" (at least for x86)

Hmm, I'd tend to leave '-M pc' as-is and enable ehci by default in the 
upcoming q35 emulation, especially in case both make it into 0.15.

> Unfortunately, msd is not yet magically healed:
>
>    non queue head request in async schedule
>    processing error - resetting ehci HC

Yea, I've seen a flaw in async handling.  Just need to dig some more 
into the code to fix it properly, also the packet workflow (including 
async handling) is one of the spots where the qemu usb subsystem needs 
some work ...

> PS: Your tree lacks conversion of usb-musb.c.

Huh?  'git diff kiszka/master kiszka/ehci hw/usb-musb.c' is empty.

cheers,
   Gerd