From mboxrd@z Thu Jan 1 00:00:00 1970 From: Juergen Gross Subject: Re: [PATCH 1 of 4] Support getting topology info in libxl Date: Wed, 08 Dec 2010 13:01:43 +0100 Message-ID: <4CFF73A7.7080704@ts.fujitsu.com> References: <37fdfe90e0c26bfac22e.1290755424@merano1.osd.mch.fsc.net> <1291805483.13966.4507.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1291805483.13966.4507.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Campbell Cc: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On 12/08/10 11:51, Ian Campbell wrote: > On Fri, 2010-11-26 at 07:10 +0000, Juergen Gross wrote: > >> diff -r 79b71c77907b -r 37fdfe90e0c2 tools/libxl/libxl.h >> --- a/tools/libxl/libxl.h Wed Nov 24 10:20:03 2010 +0000 >> +++ b/tools/libxl/libxl.h Thu Nov 25 09:29:43 2010 +0100 >> @@ -148,6 +148,13 @@ >> uint8_t *map; >> } libxl_cpumap; >> void libxl_cpumap_destroy(libxl_cpumap *map); >> + >> +typedef struct { >> + uint32_t entries; >> + uint32_t *array; >> +} libxl_cpuarray; >> +#define LIBXL_CPUARRAY_INVENTRY ~0 > > This looked at first glance like you had misspelled INVENTORY. Perhaps > LIBXL_CPUARRAY_INVALID_ENTRY? Okay, I don't mind. > >> +void libxl_cpuarray_destroy(libxl_cpuarray *array); >> >> typedef enum { >> XENFV = 1, >> @@ -464,6 +471,7 @@ >> int libxl_button_press(libxl_ctx *ctx, uint32_t domid, libxl_button button); >> >> int libxl_get_physinfo(libxl_ctx *ctx, libxl_physinfo *physinfo); >> +libxl_topologyinfo *libxl_get_topologyinfo(libxl_ctx *ctx); > > The idiom in libxl is for such functions to take a pointer to the > structure to fill in and return a status code, e.g. > int libxl_get_topologyinfo(libxl_ctx *ctx, libxl_topologyinfo *info) > e..g libxl_get_physinfo() > > This is useful since the caller doesn't always need to manage the > dynamic allocation of the info structure e.g, it can use a stack > variable for temporary stuff or nest inside another structure etc. I'll change it. Juergen -- Juergen Gross Principal Developer Operating Systems TSP ES&S SWE OS6 Telephone: +49 (0) 89 3222 2967 Fujitsu Technology Solutions e-mail: juergen.gross@ts.fujitsu.com Domagkstr. 28 Internet: ts.fujitsu.com D-80807 Muenchen Company details: ts.fujitsu.com/imprint.html