From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=36158 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PQNb3-0003Xs-IY for qemu-devel@nongnu.org; Wed, 08 Dec 2010 12:14:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PQNax-0001cn-Kt for qemu-devel@nongnu.org; Wed, 08 Dec 2010 12:14:29 -0500 Received: from mx1.redhat.com ([209.132.183.28]:62199) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PQNax-0001cB-Dr for qemu-devel@nongnu.org; Wed, 08 Dec 2010 12:14:23 -0500 Message-ID: <4CFFBCE2.1010909@redhat.com> Date: Wed, 08 Dec 2010 18:14:10 +0100 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Qemu-devel] State of EHCI emulation for QEMU References: <4CDEE6C5.3010808@web.de> <4CF988EC.6010004@redhat.com> <4CFA0462.8080407@web.de> <4CFAA2D9.3010106@cisco.com> <4CFF4142.2090603@redhat.com> <4CFF4280.30702@web.de> <4CFFA904.7030508@cisco.com> In-Reply-To: <4CFFA904.7030508@cisco.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "David S. Ahern" Cc: Jes Sorensen , Jan Kiszka , qemu-devel Hi, > Where was the messiness given that most of the changes are to a brand > new file? From the "devel -> merge with upstream -> fixup breakage + commit -> devel" cycle. When rebasing *that* you simply don't get a nice + bisectable patch series. Early patches didn't apply cleanly due to buildsystem changes. After fixing up that ehci didn't build. Of course there are likely fixup patches coming later which solve that which I could try to find + cherry-pick + squash-in. But at that point I felt it simply isn't worth the trouble given that we would squash it all together anyway for patch review + upstream merge. cheers, Gerd