From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robbert Kouprie Subject: Re: [PATCH] cifs: Support NTLM2 session security during NTLMSSP authentication Date: Wed, 08 Dec 2010 19:16:01 +0100 Message-ID: <4CFFCB61.4090807@exx.nl> References: <1291822865-26472-1-git-send-email-shirishpargaonkar@gmail.com> <20101208110608.607a23e2@tlielax.poochiereds.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Jeff Layton , smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Shirish Pargaonkar Return-path: In-Reply-To: Sender: linux-cifs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Also, Op 8-12-2010 18:28, Shirish Pargaonkar schreef: > On Wed, Dec 8, 2010 at 10:33 AM, Shirish Pargaonkar >>>> diff --git a/fs/cifs/sess.c b/fs/cifs/sess.c >>>> index 7b01d3f..122ad31 100644 >>>> --- a/fs/cifs/sess.c >>>> +++ b/fs/cifs/sess.c >>>> @@ -437,7 +437,7 @@ static void build_ntlmssp_negotiate_blob(unsigned char *pbuffer, (...) >>>> @@ -544,8 +544,9 @@ static int build_ntlmssp_auth_blob(unsigned char *pbuffer, The patch you sent me (and which I tested successfully) had an extra hunk in it: @@ -477,7 +477,7 @@ static int build_ntlmssp_auth_blob(unsigned char *pbuffer, flags = NTLMSSP_NEGOTIATE_56 | NTLMSSP_REQUEST_TARGET | NTLMSSP_NEGOTIATE_TARGET_INFO | NTLMSSP_NEGOTIATE_128 | NTLMSSP_NEGOTIATE_UNICODE | - NTLMSSP_NEGOTIATE_NTLM; + NTLMSSP_NEGOTIATE_NTLM | NTLMSSP_NEGOTIATE_EXTENDED_SEC; if (ses->server->secMode & (SECMODE_SIGN_REQUIRED | SECMODE_SIGN_ENABLED)) flags |= NTLMSSP_NEGOTIATE_SIGN; Is it your intent to leave out this hunk? Regards, Robbert